Skip to content

ci: stop main runs cancelling each other and drop the fake metrics - #140

Merged
jamesarich merged 1 commit into
mainfrom
ci/honest-build-signals
Sep 22, 2026
Merged

jamesarich merged 1 commit into
mainfrom
ci/honest-build-signals

Conversation

@jamesarich

Copy link
Copy Markdown
Collaborator

Four things in build.yml that either lie or fight the build.

Main runs cancelled each other. cancel-in-progress is keyed on workflow and ref, so each merge killed the run of the one before it. Four commits on main went unverified this way on 2026-09-22. Cancelling stays on for branches, off for main.

The dependency graph was submitted twice. dependency-submission.yml already does it, on main pushes, with contents: write. The copy passed to setup-gradle here has no such permission and logged Resource not accessible by integration on every run since it was added.

Capture Build Metrics printed fixed strings. Unit tests: 34/34 passing, Detekt: 0/0 issues, Spotless: 100% formatted, Parallel Execution: 4+ threads. Nothing measured any of them, and the test count is already wrong. Removed rather than faked; the build scan and the JUnit report carry the real numbers.

The APK guard warned on every build. Threshold 8 MB against a 20.1 MB debug APK. Raised to 24 MB, roughly 20% headroom over today's size. Worth tuning, or pointing at the release APK instead, which is the size that actually ships.

Four commits on main went unverified on 2026-09-22 because
cancel-in-progress is keyed on workflow and ref, so each merge killed the
run of the one before it. Cancelling stays on for branches.

The dependency graph was being submitted twice. dependency-submission.yml
already does it with contents: write; the copy here has no such permission
and logged "Resource not accessible by integration" on every run.

Capture Build Metrics printed fixed strings - "Unit tests: 34/34 passing",
"Detekt: 0/0 issues", "Parallel Execution: 4+ threads" - none of them
measured. Removed rather than faked.

The APK guard warned above 8 MB against a 20.1 MB debug APK, so it fired
every build. Raised to 24 MB, which is roughly 20% headroom.
@jamesarich
jamesarich added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit f12a360 Sep 22, 2026
5 checks passed
@jamesarich
jamesarich deleted the ci/honest-build-signals branch September 22, 2026 18:19
@github-actions github-actions Bot mentioned this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant