Skip to content

docs: explain SECRET_KEY env variable in README - #200

Open
markcrivera wants to merge 1 commit into
mainfrom
docs/readme-secret-key-129
Open

docs: explain SECRET_KEY env variable in README#200
markcrivera wants to merge 1 commit into
mainfrom
docs/readme-secret-key-129

Conversation

@markcrivera

Copy link
Copy Markdown
Collaborator

Summary

Documents what the SECRET_KEY environment variable is for, so operators know how to set it and what happens if they change it.

Changes

  • Added a note to README.md explaining SECRET_KEY and the need to keep it constant

Testing

Documentation only; checked rendereing

Related

Closes #129 (review request from @Amndeep7 on #10 discussion).

@markcrivera
markcrivera requested a review from Amndeep7 June 10, 2026 02:44
@Amndeep7
Amndeep7 temporarily deployed to tir-docs-readme-secret--x8g4jm June 10, 2026 02:44 Inactive
Document what SECRET_KEY is for: a server-side pepper used as the HMAC
key when hashing user passwords. Note that it must be a long random
string, kept private, and held constant since changing it invalidates
all existing password hashes.

Closes #129

Signed-off-by: Mark Rivera <mcrivera@gmail.com>
@markcrivera
markcrivera force-pushed the docs/readme-secret-key-129 branch from f36ca70 to 3ff1ab0 Compare June 10, 2026 02:50
@Amndeep7
Amndeep7 temporarily deployed to tir-docs-readme-secret--x8g4jm June 10, 2026 02:50 Inactive
@sonarqubecloud

Copy link
Copy Markdown

@markcrivera
markcrivera marked this pull request as ready for review June 10, 2026 02:51
Comment thread README.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonblocking: do you want to put the detailed explanations of the envvars in here or outsource those explanations to a wiki page like we do for Heimdall?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That a good point and I don't really know. We have the readme, soon we will have the example .env and we have the TIR docs site.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the example .env is super rough / basically just a list of the envvars so folks can more easily comment them in/out with the bare minimum amount of info you need to make a decision.

For us the wiki page is where we put the very in-depth + formatted explanation for everything.

Since it's a form of extended documentation, I think the TIR docs site could be a good place too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update README for env variables

2 participants