Safe filenames - #8480

Open

Amndeep7 wants to merge 24 commits into

mainfrom

Commits on Jun 24, 2026

simplified basename implementation
Amndeep7
committed
eb563f2
added more tests to handle more edge cases for basename functionality
Amndeep7
committed
abec723

Commits on Jun 25, 2026

modified tests to handle being concurrent better by making them independently create their tempdirs instead of generating them one at a time which could lead to race conditions when run in parallel…
Amndeep7
committed
94b153d
add a test for if the target file is a symlink since resolvesafechild only checks if the intermediate directories are symlinks not the final path - this test is currently failing
Amndeep7
committed
b984b40
add an additional check for if the target file is a symlink
Amndeep7
committed
62165af
converted as many locations as possible to use basename and/or resolvesafechild
Amndeep7
committed
59932ab
added filename sanitization
Amndeep7
committed
df0c808
add failing test for windows shell metacharacters - might need to add more characters to handle all of powershell + cmd.exe
Amndeep7
committed
ec64170
Clarifies docstring for safeFilename

Amndeep7
and
Copilot
authored
dab3f99
rename variable to make it clearer that it's a file as opposed to a directory where the results will be saved
Amndeep7
committed
0185c2d
make the shell injection work properly
Amndeep7
committed
9d04107

Commits on Jun 26, 2026

Commits on Jul 6, 2026

modify execfilesync function slightly and add more tests
Amndeep7
committed
a158354
get rid of node: prefix
Amndeep7
committed
1cb67a8

Commits on Aug 13, 2026

might be a race condition
Amndeep7
committed
9e06e0f
maybe it wasn't the race condition. trying to do more debugging now
Amndeep7
committed
85b8488
more debugging
Amndeep7
committed
c82a6ed
github actions apparently has a tilda in the path which we are very strictly blocking so let's try going to a different dir that might not have a tilda inside
Amndeep7
committed
6947694
sequential probably isn't necessary then
Amndeep7
committed
2578bc4
sonarqube says to cosolidate tests
Amndeep7
committed
d8f8bde
Merge branch 'main' into safe_filenames
Amndeep7
authored
02d0ffa

Commits on Aug 14, 2026

added text to the readme to clarify the security risks
Amndeep7
committed
f686e8e

Commits on Aug 15, 2026

Merge branch 'main' into safe_filenames
Amndeep7
authored
650cdb2