Update to Blockly 13 - #4069
Open
mjgallag wants to merge 32 commits into
Open
Conversation
RaspberryPiFoundation/blockly@59fab94 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L217-L219 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L254 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1166-L1171 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1172-L1175 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1187-L1191
https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L148-L152 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L160-L162 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L189-L193 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L195-L197 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L205-L208 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L234-L239 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L301-L304 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L345-L347
Stage the BlocklyPanel element in a hidden div before initializing the workspace. GWT later moves it into the ProjectEditor deck when the editor is added. Blockly measures a hidden workspace using computed CSS, which requires the workspace element to be attached to the document. RaspberryPiFoundation/blockly#8572
Removes staging of BlocklyPanel element in a hidden div before initializing the workspace workaround.
This reverts commit 3cc7612.
Blockly 13 switched sprites from PNG to SVG. RaspberryPiFoundation/blockly@2678f58
mjgallag
marked this pull request as ready for review
August 15, 2026 00:28
ewpatton
reviewed
Aug 20, 2026
| new YaBlocksEditor(this, (YoungAndroidBlocksNode) source)); | ||
| YaBlocksEditor newBlocksEditor = new YaBlocksEditor(this, (YoungAndroidBlocksNode) source); | ||
| addBlocksEditor(((YoungAndroidBlocksNode) source).getFormName(), newBlocksEditor); | ||
| newBlocksEditor.initWorkspace(); |
Member
There was a problem hiding this comment.
I disagree with this change. Initializing the workspace is an implementation detail of the blocks editor class and it shouldn't be up to the caller to have to manually do it. In other branches where we've introduced block editors for other platforms we will need to remember to make this change when we merge upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Description
What does this PR accomplish?
josmas/blockly-plugins#6
mit-cml/blockly-plugins#88
mit-cml/workspace-multiselect#154
TEST HERE
https://arched-branch-471517-f9.uc.r.appspot.com/
I had to map all of the single letter shortcuts due to typeblocking. I went with option/alt as it seemed to lack system conflicts.
Note the Blockly keyboard shortcut help dialog we had in 12 is not in 13 as Blockly did not move it into core from https://github.com/raspberrypifoundation/blockly-keyboard-experimentation.
Context for the changes
If this PR changes anything related to the companion make sure you have used the
ucrbranch. For all other changes usemasteror provide context for having used a different branch.See a summary of git branches in the docs: App Inventor Developer Overview
If your code changes how something works on the device (i.e., it affects the companion):
I have made no changes that affect the companion
I branched from
ucrMy pull request has
ucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
I have made no changes that affect the master branch
I branched from
masterMy pull request has
masteras the baseGeneral items:
ant testspasses on my machine