Update to Blockly 12 - #3768
Conversation
7e7c8fe to
70aba52
Compare
728f222 to
04522ff
Compare
98f30c2 to
234bd34
Compare
cda90f7 to
8c48c33
Compare
79db5ec to
9ceb0b1
Compare
|
@ewpatton this is rebased per our discussion earlier today, see 1353040. mit-cml/blockly#13 has been rebased too, now it is just a straight upgrade to 12 no new changes added to our fork. |
9ceb0b1 to
bd2f855
Compare
|
@ewpatton see bd2f855 which fixes 4fadad8 the correct but more risky way. I included both so if we need to revert to simple workaround we can. This has been deployed to https://arched-branch-471517-f9.uc.r.appspot.com. |
bd2f855 to
f98bdcd
Compare
|
I just pushed Fix D duplicate multiselect shortcut, which was new and thus needed to be implemented for multiselect. There are some small older bugs being found in multiselect that I will get addressed after blockly summit when I return but I don't think any of them are blocking in terms of this moving into testing. |
f98bdcd to
2483375
Compare
|
@ewpatton this has been rebased now that 5a760fd has merged. I have closed mit-cml/blockly#13 and removed it from description above as this PR is now Blockly v12.5.1 directly, no fork. No merge conflicts with master now. |
2483375 to
fe14f42
Compare
RaspberryPiFoundation/blockly@59fab94 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L217-L219 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L254 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1166-L1171 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1172-L1175 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1187-L1191
https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L148-L152 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L160-L162 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L189-L193 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L195-L197 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L205-L208 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L234-L239 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L301-L304 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L345-L347
Stage the BlocklyPanel element in a hidden div before initializing the workspace. GWT later moves it into the ProjectEditor deck when the editor is added. Blockly measures a hidden workspace using computed CSS, which requires the workspace element to be attached to the document. RaspberryPiFoundation/blockly#8572
Removes staging of BlocklyPanel element in a hidden div before initializing the workspace workaround.
fe14f42 to
05f4e67
Compare
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
josmas/blockly-plugins#5
mit-cml/blockly-plugins#68
mit-cml/workspace-multiselect#133
https://arched-branch-471517-f9.uc.r.appspot.com
I had to map all of the single letter shortcuts due to typeblocking. I went with option/alt as it seemed to lack system conflicts.


New App Inventor Mapping:
Default Blockly Mapping:
Resolves #3759.