Repository navigation
Conversation
…quest DTOs - deprecate AddCollectionFunctionRequest and DropCollectionFunctionRequest in favor of AddFunctionFieldRequest/DropFunctionFieldRequest (pymilvus parity) - add examples/src/v2 alias.cpp, partition.cpp and index.cpp demonstrating the alias, partition and index management APIs - general.cpp: demonstrate delete-by-ids, delete-by-filter, truncate and rename - add_field.cpp: demonstrate AlterCollectionFieldProperties on an added field - db.cpp: demonstrate AlterDatabaseProperties and DropDatabaseProperties Signed-off-by: yhmo <yihua.mo@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
===========================================
+ Coverage 53.47% 89.67% +36.20%
===========================================
Files 52 393 +341
Lines 4432 16852 +12420
Branches 0 1856 +1856
===========================================
+ Hits 2370 15112 +12742
+ Misses 2062 1740 -322
🚀 New features to boost your workflow:
|
yhmo
force-pushed
the
mm-hybrid-compaction
branch
from
September 28, 2026 08:22
f3bb6bf to
407c1c7
Compare
- HybridSearchRequest: add FunctionChains()/SetFunctionChains/ WithFunctionChains()/AddFunctionChain(); Validate() rejects function chains combined with a rerank and requires either one; the pre-callback converts each chain into the proto (pymilvus hybrid_search function_chains parity) - ListCompactionTasks: new ListCompactionTasksRequest + MilvusClientV2:: ListCompactionTasks facade that lists all retained compaction tasks of a collection via GetCompactionStateWithPlans (pymilvus list_compaction_tasks) - bump pinned milvus-proto to ae7fea6 so GetCompactionPlansRequest carries db_name/collection_name (also adds GetPersistentSegmentInfoRequest.states) - DqlUtils: guard the rerank param mapping for a null rerank function - CompactionPlan: expose the full CompactionMergeInfo surface (plan_id, trigger_id, collection_id, partition_id, channel, type, state, failure_reason, targets) and CompactionType/CompactionTaskState enums; GetCompactionPlansResponse gains CollectionName() (pymilvus Plan parity) - add unit tests for the new request members/validation and a mocked test asserting collection_name and the full plan fields on the wire response - test: switch system-test MinIO image to milvusdb/minio:RELEASE.2024-05-28T17-19-04Z Signed-off-by: yhmo <yihua.mo@zilliz.com>
yhmo
force-pushed
the
mm-hybrid-compaction
branch
from
September 28, 2026 09:31
407c1c7 to
839babd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two gaps from the C++-vs-PyMilvus parity audit (gaps #1 and #2):
1. hybrid_search
function_chainsinput (Partial)HybridSearchRequestgainsFunctionChains()/SetFunctionChains/WithFunctionChains/AddFunctionChain.Validate()now accepts either a rerank function or function chains(rejects combining them), mirroring
SearchRequest.function_chainsmember (which already existed in the pinned proto),matching pymilvus
hybrid_search(function_chains=...).2. list_compaction_tasks (Missing API)
ListCompactionTasksRequest(db + collection name).MilvusClientV2::ListCompactionTasksfacade that lists all retainedcompaction tasks of a collection via the
GetCompactionStateWithPlansRPC(same request/response shape as
GetCompactionPlansbut keyed bycollection_name), matching pymilvuslist_compaction_tasks.milvus-protocommit toae7fea6, which addsdb_name/collection_name/collection_idtoGetCompactionPlansRequest(and, as a bonus,
statestoGetPersistentSegmentInfoRequest).Supporting changes
DqlUtils::ConvertHybridSearchRequest: guard the rerank param mapping for anull rerank (function-chains path).
asserting
collection_nameon theListCompactionTaskswire request.Verified:
testing-ut(928) andtesting-it(337) pass; clang-format/cpplint clean.Signed-off-by: yhmo yihua.mo@zilliz.com