Split 'can-panic' part of midnight-ledger-helpers - #2106
Merged
Conversation
github-actions
Bot
added
the
bot:ai-assisted
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3901715fb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
LGLO
force-pushed
the
extract-can-panic-to-separate-crate
branch
from
September 8, 2026 05:35
9e7e891 to
77ad86a
Compare
LGLO
commented
Sep 8, 2026
LGLO
commented
Sep 8, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad8b2e65ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
LGLO
commented
Sep 8, 2026
LGLO
force-pushed
the
extract-can-panic-to-separate-crate
branch
from
September 8, 2026 07:00
ad8b2e6 to
3960379
Compare
gilescope
reviewed
Sep 8, 2026
gilescope
previously approved these changes
Sep 8, 2026
LGLO
force-pushed
the
extract-can-panic-to-separate-crate
branch
from
September 8, 2026 10:21
3960379 to
08e7475
Compare
… separate crate. The can-panic-gated apparatus in midnight-node-ledger-helpers (context/contract/ intent/offer/output/UTXO builders, wallet key management, the v8->v9 fork-replay helpers) exists solely to hand-build transactions and wallets for the toolkit CLI and tx generator, plus a few test suites that borrowed it as a dev-dependency. It never runs on the node's real block-execution path. Move it into a new midnight-ledger-unsafe-helpers crate so midnight-node-ledger-helpers shrinks back to the shared/production ledger glue, and drop the can-panic/test-utils features entirely now that nothing needs the opt-in. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Db7XfYwutBUzrkomMwYuEz Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
LGLO
force-pushed
the
extract-can-panic-to-separate-crate
branch
from
September 8, 2026 20:02
08e7475 to
f6f01f4
Compare
gilescope
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This refactoring stems from a comment on #2080 .
The new crate is not intended to be used with a consensus. Whole 'can-panic' feature went to the new crate, as it is not used by consensus and we can be
suremore confident that changes made there won't affect consenus unless someone makes a mistake and changes dependencies graph.🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links