Fix issue #2070. Don't fail context update when there is a

[LGLO]

Overview

Fixed #2070 by not crashing replay when there is a send_mn_transaction record of a transaction that wasn't included in Midnight Ledger because it was not well formed.

🗹 TODO before merging

• Ready

📌 Submission Checklist

• All commits are signed off (git commit -s) for the DCO
• Changes are backward-compatible (or flagged if breaking)
• Pull request description explains why the change is needed
• Self-reviewed the diff
• I have included a change file, or skipped for this reason:
• If the changes introduce a new feature, I have bumped the node minor version
• Update documentation (if relevant)
• Updated AGENTS.md if build commands, architecture, or workflows changed
• No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

• Additional tests are provided (if possible)

🔱 Fork Strategy

• Node Runtime Update
• Node Client Update
• Other:
• N/A

Links

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 263d604ec6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Keep malformed locally generated transactions as errors

This fallback also applies to the public update_from_tx path, not only historical replay. The ledger-8 batch generator calls that method at util/toolkit/src/tx_generator/builder/builders/ledger_8/batches.rs:321-323 and 480-483, then unconditionally appends the transaction; if a generated transaction fails well_formed, this branch now returns Ok without updating state, so subsequent batches can reuse the same inputs and the command can emit an invalid transaction chain instead of failing. Restrict this tolerance to block replay, while preserving InvalidTransaction for local updates.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Mirror the fallback in the ledger-9 replay path

The new handling exists only in the ledger-8 context, while LedgerVersion::from_spec_version routes every 2.0.0+ block to ledger 9 and apply_block_9 invokes the unchanged ledger_9::LedgerContext::update_from_block. Consequently, any failed send_mn_transaction whose ledger-9 well_formed check returns Err still aborts replay at ledger/helpers/src/ledger_9/context.rs:412-417, reproducing the same outage for current ledger-9 history. Apply the same replay-only fallback to the ledger-9 implementation.

Useful? React with 👍 / 👎.