Skip to content

Show all STRINGS choices in cache editor dropdown - #5023

Open
Quan Zhuo (quanzhuo) wants to merge 1 commit into
microsoft:mainfrom
quanzhuo:issues/5022
Open

Show all STRINGS choices in cache editor dropdown#5023
Quan Zhuo (quanzhuo) wants to merge 1 commit into
microsoft:mainfrom
quanzhuo:issues/5022

Conversation

@quanzhuo

Copy link
Copy Markdown
Contributor

This change addresses item #5022

This changes visible behavior

The following changes are proposed:

  • Replace the Cache Editor's native datalist control for STRINGS cache variables with a custom editable dropdown.
  • Show all declared STRINGS choices whenever the dropdown is opened, instead of filtering choices by the current input value.
  • Preserve manual text editing and invalid-choice highlighting for string cache entries.
  • Add a regression test for rendering STRINGS choices as an unfiltered popup list.

@quanzhuo
Quan Zhuo (quanzhuo) force-pushed the issues/5022 branch 2 times, most recently from 32fef60 to a0fdbe2 Compare August 4, 2026 06:29
@quanzhuo

Copy link
Copy Markdown
Contributor Author

The native datalist in VS Code webviews filters options based on the current input value and cannot be configured to always show all CMake STRINGS choices, so this replaces it with a small editable combobox implementation.

@quanzhuo

Copy link
Copy Markdown
Contributor Author

One behavior choice worth calling out: cmake-gui shows STRINGS cache entries as a non-editable dropdown. This PR keeps CMake Tools' existing editable input behavior and only fixes the filtered candidate list. I’m happy to adjust this to a non-editable dropdown if maintainers prefer matching cmake-gui exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant