[icu] Fix path to fallback install-sh - #53279
Draft
Kai Pastor (dg0yt) wants to merge 1 commit into
Draft
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icu uses
AC_PROG_INSTALLwhich tries to find a fast binaryinstalland uses a slowinstall-shscript as fallback.When the fallback is used, icu prepends
$(top_srcdir)for (some) in-source builds. But vcpkg builds out-of-source, and the value INSTALL is valid only for the toplevel build dir.So this patch prepends
$(top_builddir)instead, so that a valid path is construct for every possible case.To verify, rename
/usr/bin/installor similar before installingicu. (E.g. applyafter
vcpkg_extract_source_archive.)Alternative to / closes #52618.
Fixes #51759.
Fixes #50967.
Fixes #48887.
Fixes #48141.
Fixes #46567.