Skip to content

[icu] Fix path to fallback install-sh - #53279

Draft
Kai Pastor (dg0yt) wants to merge 1 commit into
microsoft:masterfrom
dg0yt:icu
Draft

[icu] Fix path to fallback install-sh#53279
Kai Pastor (dg0yt) wants to merge 1 commit into
microsoft:masterfrom
dg0yt:icu

Conversation

@dg0yt

Copy link
Copy Markdown
Contributor

icu uses AC_PROG_INSTALL which tries to find a fast binary install and uses a slow install-sh script as fallback.
When the fallback is used, icu prepends $(top_srcdir) for (some) in-source builds. But vcpkg builds out-of-source, and the value INSTALL is valid only for the toplevel build dir.
So this patch prepends $(top_builddir) instead, so that a valid path is construct for every possible case.

To verify, rename /usr/bin/install or similar before installing icu. (E.g. apply

vcpkg_replace_string("${SOURCE_PATH}/source/configure" "DUALCASE=1" "mv /usr/bin/install /usr/bin/install.orig\nDUALCASE=1" IGNORE_UNCHANGED)

after vcpkg_extract_source_archive.)

Alternative to / closes #52618.
Fixes #51759.
Fixes #50967.
Fixes #48887.
Fixes #48141.
Fixes #46567.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant