Skip to content

[stormlib] update to 9.40 - #53274

Draft
toge (toge) wants to merge 1 commit into
microsoft:masterfrom
toge:stormlib-9.40
Draft

[stormlib] update to 9.40#53274
toge (toge) wants to merge 1 commit into
microsoft:masterfrom
toge:stormlib-9.40

Conversation

@toge

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

https://github.com/ladislav-zezula/StormLib/releases/tag/v9.40

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.6 Sol says:

  • The generated CMake usage is not usable. find_package(StormLib CONFIG REQUIRED) creates StormLib::storm, whose interface names ZLIB::ZLIB and BZip2::BZip2 without first finding those packages, so a minimal consumer fails during generation.
  • Direct MSVC consumers cannot link the installed libraries. src/StormLib.h injects legacy names such as StormLibRAD.lib and StormLibDAD.lib, while the port installs only StormLib.lib.
  • CMakeLists.txt builds bundled LibTomCrypt and LibTomMath sources, while vcpkg.json has no SPDX license declaration and the installed copyright contains only StormLib's MIT text

I also got it to write toge#37 ; would you consider that? The only "must fix" is the licensing part.

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft August 8, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants