[stormlib] update to 9.40 - #53274
Draft
toge (toge) wants to merge 1 commit into
Draft
Conversation
Billy O'Neal (BillyONeal)
requested changes
Aug 8, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
GPT 5.6 Sol says:
- The generated CMake usage is not usable.
find_package(StormLib CONFIG REQUIRED)createsStormLib::storm, whose interface namesZLIB::ZLIBandBZip2::BZip2without first finding those packages, so a minimal consumer fails during generation.- Direct MSVC consumers cannot link the installed libraries.
src/StormLib.hinjects legacy names such asStormLibRAD.libandStormLibDAD.lib, while the port installs onlyStormLib.lib.CMakeLists.txtbuilds bundled LibTomCrypt and LibTomMath sources, whilevcpkg.jsonhas no SPDX license declaration and the installed copyright contains only StormLib's MIT text
I also got it to write toge#37 ; would you consider that? The only "must fix" is the licensing part.
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 8, 2026 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/ladislav-zezula/StormLib/releases/tag/v9.40