[hanjingo-high-jump] Update to 1.0.11 - #53272
Conversation
Remove the incorrect usage file.
- Fix project version inconsistency: pass HJ_VERSION via CMake - Add usage documentation to hjConfig.cmake.in - Fix license: GPL-3.0-only -> GPL-3.0-or-later - Remove unused dependencies: abseil, libiconv, libnice, vcpkg-cmake-config - Add default HJ_VERSION in CMakeLists.txt - Add BUILD_BENCH option
- Fix version inconsistency by passing HJ_VERSION via CMake - Add usage documentation - Remove unused dependencies
Install the Boost.Coroutine2 headers required by the unguarded core aggregate header and patch upstream headers so the aggregate header compiles cleanly with MSVC. Also update the installed CMake config's core Boost component list and include the full fmt formatting declarations used by hj/testing/debugger.hpp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c7b186e3-fc86-45e8-a903-bb87dfd375f5
[hanjingo-high-jump] Fix MSVC aggregate header integration
| REF v${VERSION} | ||
| SHA512 e7bb70810dd23649039c3565d8617e1de343251d0f0db20ee8e1ed2edd25435d1db4cffa41a4b80827ccfbfd1c3e7ef7f365907eb9a893e8ac29189bd6d95f09 | ||
| PATCHES | ||
| fix-msvc-core-headers.patch |
There was a problem hiding this comment.
- If you're removing this patch it also needs to be deleted.
- According to GPT 5.6 Sol the patch is still required:
upstream v1.0.11 still omits
NOMINMAXinhj/hj.hpp. Consequently, including<hj/hj.hpp>fails MSVC Release and Debug builds inhj/sync/counter.hppbecause Windowsmin/maxmacros expand inside the header
[...]
counter.hpp(448): warning C4003: not enough arguments for function-like macro invocation 'max' counter.hpp(448): error C2059: syntax error: '<parameter-list>' counter.hpp(470): fatal error C1201: unable to continue after syntax error
Do you think it would be a good idea to add a test port since the MINMAX mess seems to continue to be a pain?
There was a problem hiding this comment.
Thanks for pointing this out! You are right, upstream v1.0.11 hasn't addressed the NOMINMAX / max() macro conflict on MSVC yet.
I have restored fix-msvc-core-headers.patch in portfile.cmake and updated the version database accordingly. I will also fix this directly in the upstream repo in the next release by using (std::numeric_limits<T>::max)() to prevent macro expansion.
| { | ||
| "name": "hanjingo-high-jump", | ||
| "version": "1.0.10", | ||
| "version": "1.0.11", |
There was a problem hiding this comment.
Also GPT 5.6 Sol:
The manifest and generated CMake package version report 1.0.11, but upstream v1.0.11's
hj/version.hppstill defines:#define HJ_MAJOR_VERSION 1 #define HJ_MINOR_VERSION 0 #define HJ_PATCH_VERSION 10
Billy O'Neal (BillyONeal)
changed the title
No description provided.