Update imgui to v1.92.9 - #53262
Conversation
| "default-font-bitmap", | ||
| "default-font-vector" |
There was a problem hiding this comment.
There was a problem hiding this comment.
Enabling the features does not add API. Most of the end users expect the library uses its own embedded font by default. Some end users will manually disable these features and expect the behavior difference (application must add font, or it won't startup).
There was a problem hiding this comment.
The PR there suggests that it effectively fails the requirement because:
AddFontDefaultXXX() functions will assert.
There was a problem hiding this comment.
I don't think we should have these features. They comply with the letter but not the spirit of the rule. Users that want to disable the default embedded fonts should write an overlay port.
77064cf to
6ed631c
Compare
|
Should we skip right to https://github.com/ocornut/imgui/releases/tag/v1.92.9b which claims to hotfix regressions? |
|
I will close this PR and create a new PR using v1.92.9b that does not include font-related updates. |
3 participants
Changes comply with the maintainer guide.
SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
All patch files in the port are applied and succeed.
The version database is fixed by rerunning
./vcpkg x-add-version --alland committing the result.Exactly one version is added in each modified versions file.
Added
metal4feature that enable Metal 4 backend in macOS.Added
default-font-bitmapanddefault-font-vectorfeatures that embed the font data in the library, which are enabled by default.