Skip to content

[icu] force absolute path on install script. #52618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
golk (groutoutlook) wants to merge 4 commits into
base: master
Choose a base branch
from
+21 −2
Draft

[icu] force absolute path on install script. #52618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d3e256
force absolute path on install script.
groutoutlook Jun 27, 2026
0197283
run `vcpkg x-add-version icu`
groutoutlook Jun 27, 2026
f25fabb
move to patch based
groutoutlook Jun 30, 2026
261dbda
run vcpkg x-add-version again.
groutoutlook Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ports/icu/fix-install-sh-relative-path.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/source/icudefs.mk.in b/source/icudefs.mk.in
--- a/source/icudefs.mk.in
+++ b/source/icudefs.mk.in
@@ -100,8 +100,8 @@
# Installation programs

MKINSTALLDIRS = $(SHELL) $(top_srcdir)/mkinstalldirs

-INSTALL = @INSTALL@
+INSTALL = $(top_srcdir)/install-sh -c
INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@
INSTALL_SCRIPT = @INSTALL_SCRIPT@
1 change: 1 addition & 0 deletions ports/icu/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ vcpkg_extract_source_archive(SOURCE_PATH
ARCHIVE "${ARCHIVE}"
PATCHES
disable-static-prefix.patch # https://gitlab.kitware.com/cmake/cmake/-/issues/16617; also mingw.
fix-install-sh-relative-path.patch
fix_bsd_and_solaris.patch
fix_parallel_build_on_windows.patch
fix-python-path-with-spaces.patch
Expand Down
2 changes: 1 addition & 1 deletion ports/icu/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "icu",
"version": "78.3",
"port-version": 1,
"port-version": 2,
"description": "Mature and widely used Unicode and localization library.",
"homepage": "https://icu.unicode.org/home",
"license": "ICU",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3926,7 +3926,7 @@
},
"icu": {
"baseline": "78.3",
"port-version": 1
"port-version": 2
},
"ideep": {
"baseline": "2026-03-31",
Expand Down
5 changes: 5 additions & 0 deletions versions/i-/icu.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "f7d7be1f6027b4f30fcb1be15119c7e65ac1c2b6",
"version": "78.3",
"port-version": 2
},
{
"git-tree": "931a42f3b3b911ba73dbbaead4c1e0037a158efd",
"version": "78.3",
Expand Down
Loading