Skip to content

[many ports]switch to vcpkg-cmake / vckg-cmake-config part 1 - #29880

Merged
dan-shaw merged 16 commits into
microsoft:masterfrom
JackBoosY:dev/jack/cleanup_vcpkg_fixup_cmake_targets
Mar 6, 2023
Merged

[many ports]switch to vcpkg-cmake / vckg-cmake-config part 1#29880
dan-shaw merged 16 commits into
microsoft:masterfrom
JackBoosY:dev/jack/cleanup_vcpkg_fixup_cmake_targets

Conversation

@JackBoosY

Copy link
Copy Markdown
Contributor
  • Switch vcpkg_fixup_cmake_targets to vcpkg_cmake_config_fixup
  • Switch vcpkg_*_cmake to vcpkg_cmake_*
  • Add double quotes to the absolute paths.

@JackBoosY

Jack·Boos·Yu (JackBoosY) commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

There may have 500+ files so I have to split them into 5 PRs.

@jimwang118 jim wang (jimwang118) added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:code-cleanup and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Feb 27, 2023
@autoantwort

Copy link
Copy Markdown
Contributor

Have you used a script for it like in #26981?

@JackBoosY

Copy link
Copy Markdown
Contributor Author

Have you used a script for it like in #26981?

No, completely manual.

@JackBoosY

Copy link
Copy Markdown
Contributor Author

autoantwort BTW, you should keep the number of modified files in your PR to a relatively small number.

…om:JackBoosY/vcpkg; branch 'master' of https://github.com/microsoft/vcpkg into dev/jack/cleanup_vcpkg_fixup_cmake_targets
@JackBoosY

Copy link
Copy Markdown
Contributor Author

arpack-ng regression is a baseline issue.

@JackBoosY

Copy link
Copy Markdown
Contributor Author

Depends on #29935

@JackBoosY

Copy link
Copy Markdown
Contributor Author

jim wang (@jimwang118) request review.

Comment thread ports/ade/portfile.cmake
@jimwang118 jim wang (jimwang118) added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 3, 2023
@dan-shaw
dan-shaw merged commit a6cb729 into microsoft:master Mar 6, 2023
@JackBoosY
Jack·Boos·Yu (JackBoosY) deleted the dev/jack/cleanup_vcpkg_fixup_cmake_targets branch March 7, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants