[ogre] Disable share folder check - #29830
Closed
Jack·Boos·Yu (JackBoosY) wants to merge 5 commits into
Closed
Conversation
added 2 commits
February 24, 2023 15:08
Contributor
Author
Mengna Li (Adela0814)
added
the
category:port-bug
Mengna Li (Adela0814)
previously approved these changes
Feb 27, 2023
Mengna Li (Adela0814)
added
the
info:needs-maintainer-attention
| message("${PORT} currently requires the following library from the system package manager:\n Xaw\n\nIt can be installed on Ubuntu systems via apt-get install libxaw7-dev") | ||
| endif() | ||
|
|
||
| set(VCPKG_POLICY_SKIP_SHARE_FOLDER_CHECK enabled) |
Contributor
There was a problem hiding this comment.
Did you check if it can be renamed, or is it a quick fix?
If it is a quick fix, it would be worth noting this in a comment.
We have to check each affected ports, and we need to know which prots were already checked.
Contributor
Author
There was a problem hiding this comment.
I didn't look at the generated files, the modification in this PR is just a workaround.
Contributor
There was a problem hiding this comment.
Jack·Boos·Yu (@JackBoosY) I think this is fine, but I want to wait to merge this until we are sure that microsoft/vcpkg-tool#675 is ready, just in case we want the policy name to change. I will tag vcpkg-team-review to solidify the policy name.
Javier Matos Denizac (JavierMatosD)
added
requires:vcpkg-team-review
Mengna Li (Adela0814)
added
depends:different-pr
Contributor
Author
|
Mengna Li (@Adela0814) Different-PR can be removed. |
added 2 commits
April 24, 2023 10:47
…able-ogre-lint-check
Mengna Li (Adela0814)
removed
the
depends:different-pr
Mengna Li (Adela0814)
approved these changes
Apr 24, 2023
Mengna Li (Adela0814)
added
the
info:needs-maintainer-attention
Contributor
|
This should not be merged before there is a binding commitment to enforce lower-case names in
|
Billy O'Neal (BillyONeal)
added
requires:vcpkg-team-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for microsoft/vcpkg-tool#675 to avoid CI failure.