Skip to content

Fix CI crash by ensuring the "core" feature is installed for all ports. - #329

Merged
Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:mainfrom
BillyONeal:debug-abi
Jan 27, 2022
Merged

Fix CI crash by ensuring the "core" feature is installed for all ports.#329
Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:mainfrom
BillyONeal:debug-abi

Conversation

@BillyONeal

Copy link
Copy Markdown
Member

This is an attempt to fix the crash/regression in the "ci" command caused by #298

I'm pretty sure this is not a correct fix but it at least makes the ci command seem to match the last known good commit.

@JackBoosY

Copy link
Copy Markdown
Contributor

So close my PR #327.

@ras0219-msft

Copy link
Copy Markdown
Collaborator

I've opened #331 with a more generalized fix and problem explanation.

@BillyONeal

Copy link
Copy Markdown
Member Author

Closing in favor of #331

@BillyONeal

Copy link
Copy Markdown
Member Author

Reopening this because I think it may be more correct and want to further discuss with Robert.

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as ready for review January 27, 2022 20:25
@BillyONeal Billy O'Neal (BillyONeal) changed the title Attempt to fix CI crash by ensuring the "core" feature is installed for all ports. Fix CI crash by ensuring the "core" feature is installed for all ports. Jan 27, 2022
@BillyONeal
Billy O'Neal (BillyONeal) merged commit fcff088 into microsoft:main Jan 27, 2022
@BillyONeal
Billy O'Neal (BillyONeal) deleted the debug-abi branch January 27, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants