Skip to content

Add Android ARM64 release target #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jake Bailey (jakebailey) wants to merge 5 commits into
base: main
Choose a base branch
from
+18 −3
Open

Add Android ARM64 release target #4734

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16a0a70
Add Android ARM64 release target
jakebailey Jul 24, 2026
75e2d58
Disable fanotify on Android
jakebailey Jul 24, 2026
1d22b14
Use inotify by default on Android
jakebailey Jul 24, 2026
52c8ad1
Upload artifacts temporarily
jakebailey Jul 31, 2026
4a48b21
Hack in android for now
jakebailey Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Herebyfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,6 +1522,7 @@ const platforms = [
{ os: "darwin", arch: "x64", vsix: true, cert: "MacDeveloperHarden" },
{ os: "darwin", arch: "arm64", vsix: true, cert: "MacDeveloperHarden" },
{ os: "aix", arch: "ppc64" },
{ os: "android", arch: "arm64" },
{ os: "freebsd", arch: "arm64" },
{ os: "freebsd", arch: "x64" },
{ os: "linux", arch: "loong64" },
Expand All @@ -1541,7 +1542,6 @@ const ignoredGoTargets = new Map([
["android/386", "Android is not a Node runtime target TypeScript supports"],
["android/amd64", "Android is not a Node runtime target TypeScript supports"],
["android/arm", "Android is not a Node runtime target TypeScript supports"],
["android/arm64", "Android is not a Node runtime target TypeScript supports"],
["freebsd/386", "FreeBSD is experimental in Node and limited here to mainstream 64-bit x64/arm64"],
["freebsd/arm", "FreeBSD is experimental in Node and limited here to mainstream 64-bit x64/arm64"],
["linux/386", "ia32 means 32-bit x86, which TypeScript does not support for native packages"],
Expand Down
4 changes: 4 additions & 0 deletions internal/fswatch/fanotify_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/binary"
"errors"
"fmt"
"runtime"
"sync/atomic"
"unsafe"

Expand Down Expand Up @@ -187,6 +188,9 @@ func init() {
// fanotifyAvailable probes whether fanotify_init succeeds with the flags
// this backend needs.
func fanotifyAvailable() bool {
if runtime.GOOS == "android" {
return false
}
Comment thread
jakebailey marked this conversation as resolved.
fd, err := unix.FanotifyInit(fanotifyInitFlags, unix.O_RDONLY|unix.O_CLOEXEC)
if err != nil {
return false
Expand Down