Skip to content

Use plugin root for mobile app bundled assets - #486

Open
Shubham Agarwal (kanu-shubham) wants to merge 2 commits into
mainfrom
fix/mobile-plugin-root-template-references
Open

Use plugin root for mobile app bundled assets#486
Shubham Agarwal (kanu-shubham) wants to merge 2 commits into
mainfrom
fix/mobile-plugin-root-template-references

Conversation

@kanu-shubham

Copy link
Copy Markdown
Contributor

Summary

  • replace all 216 ${CLAUDE_SKILL_DIR} path references in the mobile-app plugin with normalized ${PLUGIN_ROOT} paths
  • align mobile bundled-asset resolution with the Power Pages plugin convention
  • preserve CLAUDE_PLUGIN_ROOT only as the runtime compatibility fallback alongside PLUGIN_ROOT

Validation

  • verified no ${CLAUDE_SKILL_DIR} references remain under plugins/mobile-apps
  • verified all 242 ${PLUGIN_ROOT} references in changed files resolve, including dynamic-path parent checks
  • passed repository metadata, security, environment, and keyword validators
  • passed the complete mobile-apps script test suite with 0 failures
  • passed git diff --check

Copilot AI lite review requested due to automatic review settings August 28, 2026 11:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mobile-apps plugin’s skill/reference documentation to use normalized ${PLUGIN_ROOT} paths (replacing ${CLAUDE_SKILL_DIR}), aligning asset/reference resolution with the convention already used in other plugins (e.g., power-pages).

Changes:

  • Replaced ${CLAUDE_SKILL_DIR}-relative paths with ${PLUGIN_ROOT} across mobile-apps SKILL workflows.
  • Updated intra-plugin skill calls and shared-reference links to use plugin-root-relative paths.
  • Updated mobile-apps shared reference docs to point at ${PLUGIN_ROOT}/skills/... for invoked workflows.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugins/mobile-apps/skills/setup-offline-profile/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/setup-datamodel/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/report-issue/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/preview-screens/SKILL.md Switch reference path to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/preview-offline-scope/SKILL.md Switch script/shared-instructions paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/list-connections/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/enable-tables-offline/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/edit-offline-profile/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/edit-app/SKILL.md Switch reference + validator script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/design-system/SKILL.md Switch preset reference paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/deploy/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/debug-app/SKILL.md Switch shared/reference links to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/create-mobile-app/SKILL.md Switch shared/script/agent/reference paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/assign-offline-profile/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-table-to-offline-profile/SKILL.md Switch shared/reference/script/agent paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-sharepoint/SKILL.md Switch shared/reference links to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-sample-data/SKILL.md Switch shared/reference/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/SKILL.md Switch shared/reference + internal-helper paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/add-pen-input/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/add-pdf-viewer/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/add-pdf-report/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/add-geolocation/SKILL.md Switch shared/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-native/add-camera/SKILL.md Switch shared/reference link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-dataverse/SKILL.md Switch shared/script paths to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-datasource/SKILL.md Switch shared-instructions link to ${PLUGIN_ROOT}
plugins/mobile-apps/skills/add-connector/SKILL.md Switch shared/connector reference links to ${PLUGIN_ROOT}
plugins/mobile-apps/shared/references/offline-profile-reconciliation.md Update invoked-skill paths to ${PLUGIN_ROOT}/skills/...
plugins/mobile-apps/shared/references/dataverse-offline-api.md Update recovery workflow paths to ${PLUGIN_ROOT}/skills/...

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread plugins/mobile-apps/skills/design-system/SKILL.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 28, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants