Skip to content

mobile-app /deploy: produce and verify the native wrap package - #438

Open
Vivek Ghosh (vivekghosh3) wants to merge 2 commits into
mainfrom
users/vivekghosh/codegen_template_fixes
Open

mobile-app /deploy: produce and verify the native wrap package#438
Vivek Ghosh (vivekghosh3) wants to merge 2 commits into
mainfrom
users/vivekghosh/codegen_template_fixes

Conversation

@vivekghosh3

Copy link
Copy Markdown

mobile-app /deploy: produce and verify the native wrap package

Work item: 39295492

Why

Deploying an Expo/CodeGen mobile app only produced the web bundle. The native artifacts the wrap pipeline needs — the prebuilt Hermes bundle and the customer asset package — were never generated, so wrapped apps launched without customer images/fonts or failed to wrap at all. Customers had no signal that anything was missing.

What changed

Added Step 2.4 "Native package" to the /deploy flow, between build and the offline-profile gate:

  • Runs the producers: npm run package:android and npm run package:ios, emitting the Hermes .hbc plus powerapps-customer-assets-<platform>/ for each platform.
  • Verifies the output before push: asserts Hermes magic bytes (c61fbc03) on both bundles and the presence of each platform's asset manifest.json. A silent/partial build now fails loudly instead of producing a broken wrap.
  • Toolchain gate: requires Node ≥ 20.19.4 and stops with actionable guidance (nvm use 20.19.4), since older Node crashes the native export.
  • Unconditional: runs on every deploy so the artifacts can't be skipped by accident.

Applied consistently to both the source skill and the installed-plugin copy so behaviour matches what the tool actually loads.

Impact

/deploy now yields a wrap-ready app in one step, with deterministic verification. This is the customer-facing half of the CodeGen wrap fix: the wrap pipeline consumes these prebuilt artifacts and never compiles customer JavaScript, so bundle production stays entirely on the customer's machine at deploy time.

Notes

  • Generic — no app-specific or test-specific assumptions.
  • Pairs with the pa-wrap-tools changes (39295462, 39295485) that consume these artifacts at wrap time.

Copilot AI lite review requested due to automatic review settings August 18, 2026 13:58
@vivekghosh3
Vivek Ghosh (vivekghosh3) requested a review from a team as a code owner August 18, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the mobile-apps /deploy skill workflow to include a new “Native package” step intended to generate and validate native-wrap artifacts (Hermes bytecode bundles + customer asset packages) in addition to the existing web dist/ output.

Changes:

  • Inserts Step 2.4 “Native package” into the deploy workflow sequence.
  • Adds Node version gating guidance and a pre-push verification checklist for expected native artifacts.
  • Documents expected artifact locations and how they’re consumed by the wrap pipeline.
Suppressed comments (2)

plugins/mobile-apps/skills/deploy/SKILL.md:84

  • Step 2.4 still references package:* in the stop condition and the commands to run, but those npm scripts don't exist in the template (it uses bundle:*). This will block /deploy for template-based projects.
If it prints below **v20.19.4**, STOP and tell the user to switch (`nvm use 20.19.4`, or install Node ≥ 20.19.4) and rerun. Do **not** run the `package:*` commands on older Node.

The web build above produces `dist/index.html` (the hosted Code App). Native **wrapped** apps additionally need a precompiled Hermes bundle **and** the customer's images/fonts as hash-addressed asset files, so the wrap pipeline never compiles or downloads JavaScript. Produce both platforms:

```bash
npm run package:android
npm run package:ios
**plugins/mobile-apps/skills/deploy/SKILL.md:107**
* This line still refers to `package:*`, but earlier in the step the commands should be `bundle:android` / `bundle:ios` (matching the template scripts). Keeping the old name here is confusing and suggests the wrong troubleshooting target.

If a package:* step fails, surface the error and STOP. If the app renders bundled images/fonts, also confirm each manifest.json assets array is non-empty (an empty array means the app doesn't require() any static asset yet).

</details>



---

💡 <a href="/microsoft/power-platform-skills/new/main?filename=.github/skills/code-review/SKILL.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add a `code-review` agent skill</a> or configure MCP servers for context-aware, tailored reviews. <a href="https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#mcp-servers-and-agent-skills" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn more in the docs.</a>

Comment on lines +69 to +73
**Print before starting:**
> "→ Compiling the native Hermes bundle and hash-addressed asset package for iOS and Android via `npm run package:android` + `npm run package:ios`. No JavaScript is compiled inside the wrap pipeline — it only consumes these prebuilt files. ~1–3 minutes."

**Node version gate (required).** The native `expo export` crashes on **Node < 20.19.4** — it hits `util.styleText(['yellow','inverse','bold'], …)`, which older Node rejects, failing the Metro bundle with a cryptic `ERR_INVALID_ARG_VALUE`. Check first:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a valid comment

Comment on lines +96 to +100
# Hermes magic bytes on both bundles (expect c61fbc03)
for f in dist/index.android.bundle.hbc dist/main.jsbundle.hbc; do
test -f "$f" || { echo "MISSING $f"; exit 1; }
test "$(xxd -p -l4 "$f")" = "c61fbc03" || { echo "$f is not Hermes bytecode"; exit 1; }
done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seems valid

npm run package:ios
```

Each command runs `expo export` for that platform and writes, next to `dist/index.html`:
@vivekghosh3 Vivek Ghosh (vivekghosh3) changed the title Users/vivekghosh/codegen template fixes mobile-app /deploy: produce and verify the native wrap package Aug 18, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Vivek Ghosh (@vivekghosh3) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants