Skip to content

Require structured GenPage agent messages - #275

Open
Tony Nguyen (nguyentony95) wants to merge 4 commits into
mainfrom
users/nguyentony/genpage-structured-agent-thoughts
Open

Require structured GenPage agent messages#275
Tony Nguyen (nguyentony95) wants to merge 4 commits into
mainfrom
users/nguyentony/genpage-structured-agent-thoughts

Conversation

@nguyentony95

Copy link
Copy Markdown
Contributor

Summary

  • require GenPage create, edit, and navigation-fix uploads to send structured Agent Thoughts, Summary, and Final Code sections
  • use literal \n sequences so PAC on Windows receives --agent-message as a single argument
  • require concise user-facing rationale rather than private chain-of-thought or sensitive information
  • enforce the contract for every initial upload and re-upload in Layer 1 evals

Runtime dependency

Rendering escaped structured sections requires the GenUX escaped-section support deployed with MscrmControls.UxAgentControl version 1.0.285. Merge/release this instruction change only when that runtime support is available in the target environments.

Validation

  • model-apps script tests
  • GenPage eval unit tests
  • Layer 1 smoke fixtures
  • Layer 2 smoke fixtures

Ensure create, edit, and navigation-fix uploads provide user-facing Agent Thoughts and Summary sections using PAC-safe escaped line breaks. Enforce the contract across every recorded upload in Layer 1 evals.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@microsoft-github-policy-service

Copy link
Copy Markdown

Tony Nguyen (@nguyentony95) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Tony Nguyen and others added 3 commits July 20, 2026 15:54
Require a concise step-by-step implementation summary covering applicable requirements, assumptions, major functions, UX decisions, and final verification without exposing private chain-of-thought.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bold numbered Agent Thoughts headings and require bulleted Summary items, with eval coverage for both formatting rules.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require escaped blank lines before bold numbered headings so Adaptive Cards do not merge headings into preceding text.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nguyentony95
Tony Nguyen (nguyentony95) marked this pull request as ready for review July 20, 2026 21:28
@nguyentony95
Tony Nguyen (nguyentony95) requested a review from a team as a code owner July 20, 2026 21:28
Copilot AI review requested due to automatic review settings July 20, 2026 21:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Model Apps GenPage skill and its eval harness to require a structured, PAC-safe --agent-message payload (escaped \n line breaks) so uploads consistently include user-facing “Agent Thoughts”, “Summary”, and “Final Code” sections and avoid leaking private reasoning.

Changes:

  • Tighten GenPage skill guidance to require escaped, structured --agent-message content for create/edit/navigation-fix uploads.
  • Add a new Layer 1 workflow assertion (with unit tests) that validates the structured --agent-message contract across all uploads in the workflow log.
  • Refresh Layer 1 fixtures and documentation/changelog to reflect the new contract.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
plugins/model-apps/skills/genpage/SKILL.md Documents the required structured escaped --agent-message format and updates upload examples.
plugins/model-apps/skills/genpage/edit-flow.md Aligns edit-flow upload instructions with the escaped structured --agent-message contract.
plugins/model-apps/CHANGELOG.md Notes the new structured agent-message requirement and Layer 1 enforcement.
evals/model-apps/genpage/tests/run-layer-1.test.js Updates mock artifacts to include a structured escaped --agent-message in recorded uploads.
evals/model-apps/genpage/tests/assertions-layer-1.test.js Adds unit tests covering pass/fail cases for the new agent-message contract assertion.
evals/model-apps/genpage/lib/assertions-layer-1.js Implements the new workflow assertion that validates structured escaped --agent-message on every upload.
evals/model-apps/genpage/fixtures/7-job-candidates-new-entities/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/5-kanban-task-board/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/4-case-wizard/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/2-mock-dashboard/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/2-mock-dashboard-real/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/18-sharepoint-connectors-on/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/17-weather-connectors-off/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/15-support-tickets-real/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/13-contact-localization/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/11-recruitment-pages-real/workflow-log.md Updates multi-upload fixture logs (including re-upload) to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/11-recruitment-multi-page/workflow-log.md Updates multi-page + PAGEREF re-upload fixture logs to include structured escaped --agent-message.
evals/model-apps/genpage/fixtures/1-account-card-gallery/workflow-log.md Updates fixture upload log to include structured escaped --agent-message.
evals/model-apps/genpage/evals.json Adds the new structured agent-message workflow assertion to the common checks list.
evals/model-apps/genpage/EVAL_GUIDE.md Updates eval guide documentation/counts to include the new agent-message contract requirement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +371 to +374
const summaryLines = sections[2].split('\\n').filter((line) => line.trim());
if (summaryLines.some((line) => !line.trim().startsWith('- '))) {
return fail(`upload ${index + 1} Summary items must be Markdown bullets beginning with "- "`);
}
```markdown
## Phase 6 — Deploy
- Command: `pac model genpage upload --app-id <id> --code-file <path> --data-sources '<entities>' --prompt "<full prompt>" --model <model-id> --name "<page name>" --agent-message "<description>" --add-to-sitemap`
- Command: `pac model genpage upload --app-id <id> --code-file <path> --data-sources '<entities>' --prompt "<full prompt>" --model <model-id> --name "<page name>" --agent-message "# Agent Thoughts\nStep-by-Step Processing\n<bold numbered headings and bulleted implementation details>\n# Summary\n- <summary item>\n# Final Code\n" --add-to-sitemap`
--prompt "<Full page description from plan's ## User Requirements>" `
--model "<current-model-id>" `
--agent-message "Description of what was built and any relevant details" `
--agent-message "# Agent Thoughts\nStep-by-Step Processing\n<Bold numbered headings with bulleted requirements, assumptions, major functions, UX decisions, and verification details>\n# Summary\n- <What was built>\n- <Additional relevant outcome>\n# Final Code\n" `
--prompt "<Only the changes in this upload, e.g. 'Add a search box and sort by company name'>" `
--model "<current-model-id>" `
--agent-message "Description of what was changed in this upload"
--agent-message "# Agent Thoughts\nStep-by-Step Processing\n<Bold numbered headings with bulleted edit requirements, assumptions, implementation decisions, preserved behavior, and verification details>\n# Summary\n- <What changed in this upload>\n- <Additional relevant outcome>\n# Final Code\n"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants