Skip to content

Refactor PLM to use the canonical Learning Mode analyzer - #760

Draft
Richie Gomez (richiemsft) wants to merge 1 commit into
mainfrom
refactor-plm-canonical-analyzer
Draft

Refactor PLM to use the canonical Learning Mode analyzer#760
Richie Gomez (richiemsft) wants to merge 1 commit into
mainfrom
refactor-plm-canonical-analyzer

Conversation

@richiemsft

@richiemsft Richie Gomez (richiemsft) commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Refactors plm.exe into a mode-neutral legacy WPR helper that delegates sealed-ETL decoding to learning_mode_windows::EtlDenialAnalyzer.

  • removes the duplicate EvtQuery / EvtRender analyzer;
  • supports the canonical block and allow provider vocabulary;
  • emits atomic canonical denials.json output and a structured stop result;
  • lets callers select the exact wpr -stop ETL destination with --trace-output;
  • pins both Kernel-General (learningModeLogging) and PermissiveLearningMode providers in the embedded WPR profile;
  • temporarily adapts canonical file/capability denials into the existing adjusted-config generator;
  • refuses incomplete adjusted configs when analysis is truncated and validates output collisions before capture.

Blocked on #759. This PR compiles and tests independently on main, but must not merge until #759 lands because it relies on that PR's complete block/allow and real-V2 capability analysis for correct PLM results.

🔗 References

🔍 Validation

  • cargo test -p plm --all-targets — 131 passed, 1 ignored existing diagnostic-fixture test.
  • cargo clippy -p plm --all-targets -- -D warnings
  • cargo fmt --all -- --check

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 52e48fee-23e1-4b05-803c-522812fcdda2
Copilot AI balanced review requested due to automatic review settings August 6, 2026 17:24
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants