Consolidate Learning Mode analyzer coverage - #759
Open
Richie Gomez (richiemsft) wants to merge 4 commits into
Open
Consolidate Learning Mode analyzer coverage#759Richie Gomez (richiemsft) wants to merge 4 commits into
Richie Gomez (richiemsft) wants to merge 4 commits into
Conversation
Centralize Event 27 UI vocabulary, cover every Job UI limit, and make block/allow composition tests provider-accurate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e48fee-23e1-4b05-803c-522812fcdda2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e48fee-23e1-4b05-803c-522812fcdda2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e48fee-23e1-4b05-803c-522812fcdda2
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Consolidates Learning Mode ETL analysis so block/permissive traces share the same canonical UI vocabulary and capability-denial extraction (including permissive Event 14 DACL-derived capability denials).
Changes:
- Added a canonical UI violation vocabulary module and updated Learning Mode violation extraction to use it.
- Extended TDH decoding to render binary properties as
hex:strings and added capability recovery from permissive Event 14 DACL data. - Updated ETL analyzer composition/tests to include recovered capability denials and enforce provider/event vocabulary.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/backends/learning_mode/windows/src/ui.rs | Introduces canonical Event 27 UI violation naming and tests. |
| src/backends/learning_mode/windows/src/tdh_decode.rs | Adds TDH_INTYPE_BINARY formatting as hex: for downstream parsing. |
| src/backends/learning_mode/windows/src/lib.rs | Registers new capability_dacl and ui modules on Windows. |
| src/backends/learning_mode/windows/src/extractors.rs | Switches Event 27 parsing to numeric category/detail and canonical UI names; adds tests. |
| src/backends/learning_mode/windows/src/etl_decode.rs | Composes DACL-derived capability denials alongside canonical extraction; updates tests/helpers. |
| src/backends/learning_mode/windows/src/capability_dacl.rs | New module to recover capability denials from permissive Event 14 DACL/ACE data with tests. |
8 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e48fee-23e1-4b05-803c-522812fcdda2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Consolidates Learning Mode block and permissive-event analysis behind the canonical ETL analyzer.
JOB_OBJECT_UILIMIT_*value;CapabilitySidproperties;🔗 References
🔍 Validation
cargo test -p learning_mode_windows --all-targets— 140 passed.cargo fmt --all -- --checkcargo clippy -p learning_mode_windows --all-targets -- -D warnings✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow