Migrate 9p file system to new backend - #1113
Migrate 9p file system to new backend#1113Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 13 commits into
Conversation
a8c0e83 to
0f74181
Compare
|
ℹ️ Note: This semver check was run against the 🤖 SemverChecks 🤖 Click for details |
|
Similar to other migrations, it is easiest to review one commit at a time. |
|
GPT-5.6 Sol: Requested changes—found 5 issues: • High: O_CREAT | O_EXCL | O_TRUNC may truncate an existing file before returning AlreadyExists ( nine_p/mod.rs:417-425 , resolver.rs:526-530 ). |
| } | ||
| // It means that the walk failed at the nwqid-th element | ||
| if new_len < chunk.len() { | ||
| // XXX: Per 9P2000.L the server does not establish `new_f` on a short walk, so not |
There was a problem hiding this comment.
Weiteng Chen (@CvvT) do you remember why we have a clunk here?
Weidong Cui (wdcui)
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Please take a look at the issues reported by GPT-5.6 sol.
3e69d02 to
c538da9
Compare
|
Thanks Weidong, quick notes on the issues your agent raised:
Note to myself: need to rebase after #1111 is merged before I merge |
This PR switches our 9p filesystem to the new core file system design (see #887). Like prior migrations, it adds a new backend, migrates all old usages to a resolver-backed one to use the new backend, and then removes the old
FileSystemobject.Additionally, as a drive-by-fix, the old
read_dir's check reports every entry as a regular file (because it looked ate.typrather thane.qid.typ); the new backend fixes this.