feat(skills): add UX design capability and accessibility Design Intent Records - #2611
Open
Bill Berry (WilliamBerryiii) wants to merge 3 commits into
Open
feat(skills): add UX design capability and accessibility Design Intent Records#2611Bill Berry (WilliamBerryiii) wants to merge 3 commits into
Bill Berry (WilliamBerryiii) wants to merge 3 commits into
Conversation
…t Records Add two design-thinking skills, extend the accessibility skill with a Design Intent Record contract, and reconcile the routing agents, collections, evals, and generated documentation that describe them. ux-artifacts produces durable evidence-labelled UX assets in five modes: frame-needs, map-journey, sketch-structure, decide-inclusion, and prepare-handoff. Every claim carries an Observed, Reported, or Assumed evidence class, and unresolved items stay visible. ux-coaching supports problem framing, critique, and stakeholder advocacy as conversation. Completed assets map to Figma or Mural as destination intent only. Mapping never authenticates, selects tools, or writes externally. Callers supply destination-kind, destination-target, and for Figma destination-change; a missing value returns a bounded missing-input result rather than an inferred one. The accessibility skill gains a Design Intent Record contract, authored and verification JSON schemas, the Validate-DesignIntent.ps1 validator with contract regression tests, runtime probe intent and projection modules, and a graphics ARIA and SVG AAM framework reference. dt-coach, the canonical deck, and coaching-state references are reconciled with the new UX routes so coaching and artifact production do not overlap. Collections, plugin outputs, extension manifests, and generated reference documentation are regenerated by their owners. Behavior coverage is extended in the skill behavior-conformance suite and the agent behavior specs. The agent scenario set and generator drift state are unchanged. The written Markdown asset stays authoritative; a rendered projection never supersedes it. Technical accessibility conformance and COGA guidance remain owned by the accessibility skill. Refs #2609
Reconciles the UX design capability work with the packaging restructure in #2577, which replaced collection- and symlink-based packaging with marketplace-owned immutable snapshots. Conflict resolutions: - collections/*.collection.{md,yml}: accepted deletion. The collection manifest architecture no longer exists; package membership moved to .github/plugin/marketplace.json. - plugins/**: accepted deletion, including the six ux-artifacts and ux-coaching symlinks this branch had added. Tracked plugin output and mode 120000 entries are now prohibited. - package.json: took main's validate:local chain, which drops lint:collections-metadata and adds lint:extension-artifact-naming, then reinserted this branch's lint:design-intent lane after lint:hooks. - scripts/extension/Prepare-Extension.ps1 and its tests: took main's version. This branch's changes targeted collection README generation, which main removed entirely. - docs/reference/**/README.md: took main's version, then regenerated. The two new skills are registered in marketplace.json for the design-thinking, hve-core-all, and project-planning packages, each at preview maturity to satisfy the cross-package maturity contract. Validation after resolution: marketplace 14 plugins OK, 59 skills with 0 errors and 0 warnings, docs generation drift-free at 264 unchanged, frontmatter and JSON lint clean, no tracked symlinks, no whitespace errors.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
+ Coverage 83.10% 87.88% +4.77%
==========================================
Files 164 114 -50
Lines 22254 11514 -10740
Branches 29 29
==========================================
- Hits 18495 10119 -8376
+ Misses 3756 1392 -2364
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Eval Execution❌ Status: Failed — 2 spec(s) block merge
|
Removes 14 Design Thinking session capture files under docs/design-thinking/ux-ui-designer-agent/ that were swept into the initial commit by a blanket stage. They are raw working notes: request stacks, assumption logs, research plans, and clustering scratch. Nothing references them, they were never intended as published documentation, and the parent task's plan had already identified them as separate in-flight branch work that this task must not absorb. Their removal also clears 76 of the 92 spell-check findings, which were informal prose and verbatim quotes rather than product content. Remaining lint fixes: - Applied ruff formatting to runtime_a11y/_intent.py. - Normalized "sceptical" to "skeptical" in the ux-coaching skill, the ux-ui-designer agent, the skill behavior eval, and the generated reference page, matching the repository's en dictionary. - Added seven terms to .cspell.json: ddat, decompos, exclu, licence, preserv, ungated, and Wireframing. All are grader regex stems, an eval grader name, a contract reference, or the official Open Government Licence spelling. Regenerated the affected reference pages and extension package READMEs. Documentation generation reports no drift at 264 unchanged. Validation: spell-check 0 unknown words, ruff clean across 36 files, 59 skills with 0 errors and 0 warnings, marketplace 14 plugins OK, frontmatter clean, no whitespace errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds a UX design capability to HVE Core and extends the accessibility skill with a Design Intent Record contract, so UX practice, engineering handoff, and accessibility verification share one evidence model.
Two new skills join the
design-thinkingcollection, routed by the existingux-ui-designeragent:ux-artifactsproduces durable, evidence-labelled UX assets in five modes:frame-needs,map-journey,sketch-structure,decide-inclusion, andprepare-handoff. Every claim carries an evidence class of Observed, Reported, or Assumed, and unresolved items stay visible rather than becoming invented research.ux-coachingsupports problem framing, design critique, and stakeholder advocacy as a conversation rather than an artifact.Completed assets can be mapped to Figma or Mural. Mapping produces destination intent only; it never authenticates, selects tools, or performs an external write. Callers supply
destination-kind,destination-target, and, for Figma,destination-change. A missing value returns a bounded missing-input result naming the absent fields instead of inferring one.The accessibility skill gains a Design Intent Record contract, authored and verification JSON schemas, the
Validate-DesignIntent.ps1validator with contract regression tests, runtime probe intent and projection modules, and a Graphics ARIA and SVG AAM framework reference. A newlint:design-intentscript joins thevalidate:localaggregate.dt-coach, the canonical deck, and the coaching-state references are reconciled with the new UX routes so coaching and artifact production do not overlap. Collections, plugin outputs, extension manifests, and generated reference documentation are regenerated by their owners.The written Markdown asset stays authoritative. A Figma, FigJam, or Mural rendering is a projection and never supersedes it. Technical accessibility conformance and COGA guidance remain owned by the
accessibilityskill; UX assets route conformance questions there rather than answering them.Related Issue(s)
Closes #2609
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
hve-builderand addressed all actionable findings.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md).github/hooks/*/*.json)evals/)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
Execution Flow:
ux-ui-designeragent recognises the request as artifact production rather than coaching, and asks a single routing question only if the request matches more than one capability.ux-artifactswithmode=map-journey,project,subject, and the coachingoutput_refpassed as the explicitsource.references/evidence-model.md, then loads only the selected mode reference.destinationwas supplied, no destination reference loads and no mapping occurs.Output Artifacts:
Success Indicators:
The asset exists at the canonical path, every claim sits under an evidence heading, and stages without evidence appear under
Unresolvedrather than being filled in. No external write occurred and no Figma or Mural content was produced. Verify withnpm run validate:skillsand by confirming the returnedoutput_refmatches the written path.Testing
Local validation lanes run against the changed content:
npm run validate:skillsnpm run lint:frontmatternpm run lint:ai-artifactsnpm run lint:asset-docsnpm run docs:generate:checknpm run lint:collections-metadatanpm run lint:yamlnpm run lint:jsonnpm run lint:pynpm run lint:tablesnpx markdownlint-cli2on changed docsgit diff --checkValidate-DesignIntent.Tests.ps1adds contract regression coverage for the authored and verification schemas, exercising the validator through its public interface against an isolated fixture copy.Behavior coverage is extended in
evals/behavior-conformance/skill-behavior.eval.yamland the agent behavior stimuli and expectations.Build-AgentBehaviorSpec.ps1 -WhatIfreports no drift, and the agent scenario set is unchanged.npm run lint:md-linkswas not run in this pass. Link checking is covered by CI.Checklist
Required Checks
AI Artifact Contributions
hve-builderreview mode to review contributionhve-builderreviewRequired Local Checks
The following local-safe validation commands must pass before merging:
npm run validate:localnpm run validate:docsnpm run spell-checknpm run lint:md-linksSecurity Considerations
No dependencies were added or changed. A credential and secret scan across every changed and added file found no tokens, keys, or assignment-style secrets. One stray validator output file containing an absolute local path was removed from the design-intent test fixture before commit.
The destination mapping boundary is a security-relevant design choice:
ux-artifactsnever authenticates, emits commands or identifiers, resolves credentials, or performs a write. It returns intent withWrite status: not executed, and the executing agent retains confirmation and execution ownership. Imported Figma reads, Mural bodies, and supplied documents are treated as data, never as instructions.Additional Notes
This is a large PR spanning four related areas that share regenerated aggregates. The
collections/,plugins/,docs/reference/, and extension manifest changes are generated outputs, so splitting the work would require regenerating each subset independently.Two items are deliberately out of scope. Native Figma and Mural execution is not implemented and no external-write behavior is claimed anywhere in the artifacts. Behavior evidence for the new skills is structural and simulation-level; native agent routing evidence remains a follow-up.
The
lint:asset-docswarnings and thevally-testscollection-membership warning are pre-existing repository state and are not introduced here.🎨 - Generated by Copilot