feat(skills): add change-risk model reference for code-review depth selection - #2550
Conversation
| ## Tier model | ||
|
|
||
| Review depth is a verification-rigor dial, not a lane-selection mechanism. The selected perspectives determine which review lanes run; the selected depth tier determines how deeply each lane verifies the confirmed change scope. | ||
| Review depth is a verification-rigor dial, not a lane-selection mechanism. The selected perspectives determine which review lanes run; the selected depth tier determines how deeply each lane verifies the confirmed change scope. Depth-tier recommendations are driven by the evidence provided in the **Change-Risk Profile** (see [Change-Risk Model](change-risk-model.md)), mapping deterministic, git-computable signals to verification rigor rather than relying on heuristic "gut feel". |
There was a problem hiding this comment.
Nit: the ms.date frontmatter field was not updated in any of the three modified files. Repo convention requires updating this field to the edit date whenever a file that carries it is changed. Applies to depth-tiers.md (2026-06-18), context-bootstrap.md (2026-06-26), and severity-taxonomy.md (2026-06-18); all should be updated to 2026-07-29.
|
The new 10. [Change-Risk Model](references/change-risk-model.md) — deterministic signal taxonomy and scoring rubric for evidence-based change-risk profiling. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
- Coverage 82.53% 82.47% -0.06%
==========================================
Files 155 143 -12
Lines 21123 21033 -90
Branches 13 0 -13
==========================================
- Hits 17434 17348 -86
+ Misses 3687 3685 -2
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1210811 to
8f57304
Compare
| 4. Present the emerging brief and hotspot candidates to the human for confirmation and correction. | ||
| 5. Invite the human to add or remove hotspots and to mark out-of-scope areas before review lanes dispatch. | ||
| 6. Persist the confirmed brief, the scoped hotspot list, the tagged specialist concerns, and out-of-scope areas as the review context for later aggregation. | ||
| 2. Draft a **Change-Risk Profile** alongside the change brief using the deterministic signals defined in [Change-Risk Model](change-risk-model.md). Evaluate Likelihood (size, diffusion, entropy), Severity (path criticality), Detectability (test presence), and Recoverability (rollback markers) using `git log` and `git diff` heuristics. |
There was a problem hiding this comment.
"Heuristics" in step 2 contradicts the "deterministic" framing established in the change-risk-model.md document that this step directly cites. The model opens with: "All signals are computable deterministically using git log and git diff." Please replace "heuristics" with "signals":
...Evaluate Likelihood (size, diffusion, entropy), Severity (path criticality),
Detectability (test presence), and Recoverability (rollback markers) using
`git log` and `git diff` signals.
Description
Implements Phase 1 of the quantitative change-risk modelling proposal for the
code-reviewskill. This PR adds a documentation-only reference (change-risk-model.md) that defines a deterministic, git-computable signal taxonomy (Likelihood, Severity, Detectability, Recoverability) alongside agentic-era modifiers.It replaces heuristic "gut-feel" risk assessment with an evidence-based Change-Risk Profile. The profile is computed during the Tier 0 context bootstrap and directly informs human-confirmed scoping, hotspot ranking, and depth-tier selection without acting as a hard gate.
Related Issue(s)
Resolves #2501
Type of Change
(Note: Updates reference files within the existing
code-reviewskill. Does not alterSKILL.mdor add executable scripts.)Sample Prompts
N/A — Documentation-only reference update. No new executable AI artifacts, prompts, or scripts were added.
Testing
Documentation only. Verified markdown formatting, heading hierarchy, and internal link resolution.
Local validation commands successfully run against changed files:
npm run spell-check✅npm run validate:skills✅npm run lint:md-links✅ (Validated links in all 4 modified files)Checklist
Required Checks
AI Artifact Contributions
hve-builderreview mode to review contribution (N/A - Documentation only)hve-builderreview (N/A)Required Local Checks
npm run validate:local(Skipped - targeted checks run instead)npm run validate:docs(Skipped - targeted checks run instead)npm run spell-checknpm run lint:md-linksnpm run validate:skillsSecurity Considerations
Additional Notes
This PR strictly implements the "Definition of Done" for Phase 1 (knowledge-level model) as requested in #2501.
Strict Scope Constraints Met:
SKILL.md) changes.Out of Scope (Follow-up Sub-issues):
If this foundational reference is accepted, subsequent issues will be filed for:
change-riskskill (bash + PowerShell parity, Pester tests, 80% coverage) emitting the profile as JSON.