PR suggestions - #955
Merged
sheetalarkadam merged 3 commits intoAug 6, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The process-wide cache can become stale across manager instances and does not cache the expensive certificate loading it intends to optimize.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Caches CA bundle configuration for libcurl-based HTTP operations.
Changes:
- Adds shared curl transport options.
- Applies cached options to HTTP and blob downloads.
- Caches
SSL_CERT_FILElookup.
File summaries
| File | Description |
|---|---|
sdk_v2/cpp/CMakeLists.txt |
Adds curl transport source. |
sdk_v2/cpp/src/download/blob_downloader.cc |
Reuses cached curl options. |
sdk_v2/cpp/src/http/curl_transport.cc |
Implements options cache. |
sdk_v2/cpp/src/http/curl_transport.h |
Declares cached options API. |
sdk_v2/cpp/src/http/http_client.cc |
Caches CA path and uses shared options. |
sdk_v2/cpp/src/http/http_client.h |
Documents cached CA path behavior. |
sdk_v2/cpp/src/http/http_download.cc |
Uses shared curl options. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cert file can be quite large on Android (IIRC > 50 system certs on the device tested a while ago). Suggestions to cache that as well as the CurlTransportOptions to minimize cost given the certs (AFAIK) aren't expected to change during the lifetime of the FL manager.Ignore that description. My mental model was off. Changes are a lot more minor after injecting reality.
sheetalarkadam pick-and-choose anything you want. PR targets your branch if you want it all.