ci: run post-merge package builds against PROD too - #18334
ci: run post-merge package builds against PROD too#18334reuben olinsky (reubeno) wants to merge 1 commit into
Conversation
Fan out the post-merge Control Tower package build across DEV and PROD using deployment-specific endpoints and service connections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fans out post-merge package builds across DEV and PROD Control Tower deployments.
Changes:
- Adds deployment-specific audiences, endpoints, and service connections.
- Runs parallel build jobs with isolated artifacts per deployment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ado/package-build.yml |
Configures DEV and PROD deployments. |
.github/workflows/ado/templates/package-build-stages.yml |
Generates one parallel build job per deployment. |
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
| steps: | ||
| # Sets job variables: | ||
| # - changedComponentsFile | ||
| - template: steps/get-changes-info.yml |
There was a problem hiding this comment.
issue(blocking): does this need to move this out of the fan-out? What is the worst case if we run both with different values here (ie infra flakes out for one query). If its harmless, this is fine.
There was a problem hiding this comment.
I considered this: it's more optimal to split it out as a first stage but adds complexity. On top of that, we're also planning to turn off scratch builds in dev anyhow once we complete cutover to prod.
For the short term, I think the worst case is that dev and prod could end up building different packages post-merge, with any missing ones caught in the next true-up nightly build. (There's a risk that also means divergence in package outputs because they could possibly be built in different orders? But the two environments have already diverged anyhow -- and it's a non-goal to keep them identical in that sense right now.)
Fan out the post-merge Control Tower package build across DEV and PROD using deployment-specific endpoints and service connections.