Support Docker-style network aliases in wslc

[David Negstad (danegsta)]

Summary of the Pull Request

This adds Docker-style per-network alias support to wslc container run and wslc container create so aliases can be scoped directly in each --network value. This makes multi-network container creation less ambiguous while preserving the existing --network-alias behavior for single-network cases.

PR Checklist

• Closes: Support network aliases in wslc container run/create --network arguments #40970
• Communication: N/A - opening for maintainer review
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: N/A
• Documentation updated: N/A

Fixes #40970

Detailed Description of the Pull Request / Additional comments

The CLI now accepts Docker-style network values such as --network name=my-net,alias=api,alias=backend, including values where alias appears before name. Parsed aliases are carried through the container task model into the service and launcher layers, then passed as endpoint settings for both the primary and additional network attachments.

Alias validation remains scoped to user-defined networks: aliases are rejected for built-in bridge, host, none, and container: networking modes, and ambiguous --network-alias usage with multiple networks is still rejected. The lower-level endpoint setting parser only accepts the Aliases key so unsupported endpoint settings fail explicitly.

Validation Steps Performed

• Ran cmake --fresh . after setting up the Windows build environment.
• Ran the Windows build successfully before local dev-loop deployment configuration was added.
• Ran focused build after parser/localization changes: cmake --build . --target wslc wsltests -- -m.
• Ran elevated network alias test subset: bin\x64\Debug\test.bat /name:*NetworkAlias*.
• Smoke tested with a real deployed wslc.exe: created user-defined networks, started containers with per-network aliases, confirmed inspect output included the aliases, and verified DNS alias resolution from peer containers on the same network.

[Copilot]

Pull request overview

This PR adds Docker-style per-network alias parsing for wslc container run/create (e.g. --network name=net,alias=a,alias=b), carries aliases through the container options/model into the launcher and session layers, and ensures aliases are applied on both primary and additional network endpoints.

Changes:

• Parse --network values into { name, aliases[] } and validate new error cases (empty alias, duplicate name=, unsupported option keys).
• Plumb per-network aliases through the container model/service/launcher into WSLCNetworkConnection.Settings (endpoint settings) for additional networks and into the primary endpoint configuration.
• Add/adjust unit + e2e coverage for multi-network Docker-style alias behavior and for rejecting unsupported endpoint settings.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/windows/WSLCTests.cpp	Updates endpoint-settings rejection test and adds coverage for aliases across primary + additional networks.
test/windows/wslc/WSLCCLIExecutionUnitTests.cpp	Updates expectations for new Networks model shape and adds parser unit tests for Docker-style --network ... alias=....
test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp	Adds e2e test ensuring Docker-style aliases work across multiple networks for container run.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp	Adds e2e test ensuring Docker-style aliases work across multiple networks for container create.
src/windows/wslcsession/WSLCContainer.cpp	Implements endpoint settings parsing for Aliases and rejects unsupported keys; applies alias validation for primary/additional endpoints.
src/windows/wslc/tasks/ContainerTasks.cpp	Populates ContainerOptions.Networks with parsed Name + Aliases from --network.
src/windows/wslc/services/ContainerService.cpp	Validates alias support by network mode and forwards per-network aliases into the launcher.
src/windows/wslc/services/ContainerModel.h	Introduces ContainerNetwork and ParseNetworkArgument() to parse Docker-style --network values.
src/windows/wslc/arguments/ArgumentValidation.cpp	Validates new parse errors for --network (empty alias, duplicate name, unsupported keys).
src/windows/service/inc/wslc.idl	Documents that per-endpoint settings are KVP-encoded and may include duplicate keys.
src/windows/common/WSLCContainerLauncher.h	Extends launcher API/storage to support additional-network aliases.
src/windows/common/WSLCContainerLauncher.cpp	Encodes additional-network aliases into WSLCNetworkConnection.Settings as repeated Aliases KVPs.
localization/strings/en-US/Resources.resw	Adds new CLI validation strings for duplicate name= and unsupported --network options.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

[beena352]

LGTM! Thanks for addressing the feedback. Blue (@OneBlue) could you take a look?

[Blue (OneBlue)]

Overall structure LGTM. Couple minor comments

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

[Blue (OneBlue)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

localization/strings/en-US/Resources.resw:2995

• The for WSLCCLI_NetworkUnsupportedOptionError includes two {FixedPlaceholder="{}"} markers, but tools/devops/validate-localization.py’s generate_string_comment() emits only a single FixedPlaceholder marker when any insert exists. With two markers, the validator’s expected substring won’t match contiguously and localization validation is likely to fail.

    <comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

[Blue (OneBlue)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

[Blue (OneBlue)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).