-
Notifications
You must be signed in to change notification settings - Fork 825
FEAT: GUI view last_score of Attack Results #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbolor21
wants to merge
13
commits into
microsoft:main
Choose a base branch
from
jbolor21:jbolor/GUI_load_scores
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+849
−28
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0477260
add initial files with scores from DB reflected in GUI
jbolor21 e4755ed
address comments
jbolor21 a4bf7af
Merge remote-tracking branch 'origin/main' into jbolor/GUI_load_scores
jbolor21 87f0dd9
clean up
jbolor21 3765845
add tests
jbolor21 9a8915e
address comments
jbolor21 8f316a6
merge conflict
jbolor21 8c199d2
copilot comment address
jbolor21 729fc8f
Merge remote-tracking branch 'origin/main' into jbolor/GUI_load_scores
jbolor21 45761db
Merge branch 'jbolor/GUI_load_scores' of https://github.com/jbolor21/…
jbolor21 cb4a4b6
Merge branch 'main' into jbolor/GUI_load_scores
jbolor21 2fec19d
Merge remote-tracking branch 'origin' into jbolor/GUI_load_scores
jbolor21 827e3bf
Merge remote-tracking branch 'origin' into jbolor/GUI_load_scores
jbolor21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { makeStyles, tokens } from '@fluentui/react-components' | ||
|
|
||
| export const useAttackVerdictChipStyles = makeStyles({ | ||
| chip: { | ||
| display: 'inline-flex', | ||
| alignItems: 'center', | ||
| columnGap: tokens.spacingHorizontalXS, | ||
| }, | ||
| chipLabel: { | ||
| textTransform: 'capitalize', | ||
| }, | ||
| surface: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| rowGap: tokens.spacingVerticalXS, | ||
| minWidth: '240px', | ||
| maxWidth: '360px', | ||
| }, | ||
| row: { | ||
| display: 'flex', | ||
| columnGap: tokens.spacingHorizontalS, | ||
| }, | ||
| rowLabel: { | ||
| minWidth: '72px', | ||
| color: tokens.colorNeutralForeground2, | ||
| }, | ||
| rationaleBlock: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| rowGap: tokens.spacingVerticalXXS, | ||
| marginTop: tokens.spacingVerticalXS, | ||
| paddingTop: tokens.spacingVerticalXS, | ||
| borderTop: `1px solid ${tokens.colorNeutralStroke2}`, | ||
| }, | ||
| rationaleText: { | ||
| color: tokens.colorNeutralForeground2, | ||
| whiteSpace: 'pre-wrap', | ||
| wordBreak: 'break-word', | ||
| maxHeight: '30vh', | ||
| overflowY: 'auto', | ||
| }, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { render, screen, within } from '@testing-library/react' | ||
| import userEvent from '@testing-library/user-event' | ||
| import { FluentProvider, webLightTheme } from '@fluentui/react-components' | ||
| import AttackVerdictChip from './AttackVerdictChip' | ||
| import type { ScoreView } from '../../types' | ||
|
|
||
| const TestWrapper: React.FC<{ children: React.ReactNode }> = ({ children }) => ( | ||
| <FluentProvider theme={webLightTheme}>{children}</FluentProvider> | ||
| ) | ||
|
|
||
| const sampleScore: ScoreView = { | ||
| id: 'score-1', | ||
| scorer_type: 'SelfAskRefusalScorer', | ||
| score_type: 'true_false', | ||
| score_value: 'true', | ||
| score_category: ['refusal'], | ||
| score_rationale: 'The model refused the request.', | ||
| timestamp: '2026-01-15T11:00:00Z', | ||
| } | ||
|
|
||
| describe('AttackVerdictChip', () => { | ||
| it('renders nothing when there is no score', () => { | ||
| render( | ||
| <TestWrapper> | ||
| <AttackVerdictChip outcome="failure" score={null} /> | ||
| </TestWrapper> | ||
| ) | ||
|
|
||
| expect(screen.queryByTestId('attack-score-chip')).not.toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('shows only the score value on the chip, labeled "Score"', () => { | ||
| render( | ||
| <TestWrapper> | ||
| <AttackVerdictChip outcome="failure" score={sampleScore} /> | ||
| </TestWrapper> | ||
| ) | ||
|
|
||
| const chip = screen.getByRole('button', { name: /score true/i }) | ||
| expect(within(chip).getByText('Score')).toBeInTheDocument() | ||
| expect(within(chip).getByText('true')).toBeInTheDocument() | ||
| // The outcome word must never appear on the chip itself. | ||
| expect(within(chip).queryByText(/failure/i)).not.toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('opens a popover with full score details when clicked', async () => { | ||
| const user = userEvent.setup() | ||
| render( | ||
| <TestWrapper> | ||
| <AttackVerdictChip outcome="failure" score={sampleScore} /> | ||
| </TestWrapper> | ||
| ) | ||
|
|
||
| await user.click(screen.getByRole('button', { name: /score true/i })) | ||
|
|
||
| const details = await screen.findByTestId('attack-score-details') | ||
| expect(within(details).getByText('true_false')).toBeInTheDocument() | ||
| expect(within(details).getByText('SelfAskRefusalScorer')).toBeInTheDocument() | ||
| expect(within(details).getByText('refusal')).toBeInTheDocument() | ||
| expect(within(details).getByText('The model refused the request.')).toBeInTheDocument() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import { | ||
| Button, | ||
| Text, | ||
| Badge, | ||
| Popover, | ||
| PopoverTrigger, | ||
| PopoverSurface, | ||
| } from '@fluentui/react-components' | ||
| import type { AttackOutcome, ScoreView } from '../../types' | ||
| import { resolveOutcome } from '../../utils/attackOutcome' | ||
| import { getScoreColor } from '../../utils/scoreColor' | ||
| import { useAttackVerdictChipStyles } from './AttackVerdictChip.styles' | ||
|
|
||
| interface AttackVerdictChipProps { | ||
| outcome?: AttackOutcome | null | ||
| score?: ScoreView | null | ||
| } | ||
|
|
||
| export default function AttackVerdictChip({ outcome, score }: AttackVerdictChipProps) { | ||
| const styles = useAttackVerdictChipStyles() | ||
|
|
||
| // Only the score value is surfaced in the ribbon, so there's nothing to show without a score. | ||
| if (!score) return null | ||
|
jbolor21 marked this conversation as resolved.
Outdated
|
||
|
|
||
| const resolvedOutcome = resolveOutcome(outcome) | ||
| const categories = score.score_category?.filter(Boolean) ?? [] | ||
| const scoreColor = getScoreColor(score.score_type, score.score_value) | ||
| const scoreBadgeStyle = { | ||
| backgroundColor: scoreColor.background, | ||
| borderColor: scoreColor.background, | ||
| color: scoreColor.foreground, | ||
| } | ||
|
|
||
| return ( | ||
| <Popover withArrow> | ||
| <PopoverTrigger disableButtonEnhancement> | ||
| <Button | ||
| appearance="subtle" | ||
| className={styles.chip} | ||
| data-testid="attack-score-chip" | ||
| aria-label={`Score ${score.score_value}`} | ||
| > | ||
| <span className={styles.chipLabel}>Score</span> | ||
| <Badge appearance="filled" size="medium" style={scoreBadgeStyle}> | ||
| {score.score_value} | ||
| </Badge> | ||
|
jbolor21 marked this conversation as resolved.
|
||
| </Button> | ||
| </PopoverTrigger> | ||
| <PopoverSurface> | ||
| <div className={styles.surface} data-testid="attack-score-details"> | ||
| <Text weight="semibold" size={300}>Score</Text> | ||
| <div className={styles.row}> | ||
| <Text size={200} weight="semibold" className={styles.rowLabel}>Value</Text> | ||
| <Badge appearance="filled" size="small" style={scoreBadgeStyle}> | ||
| {score.score_value} | ||
| </Badge> | ||
| </div> | ||
| <div className={styles.row}> | ||
| <Text size={200} weight="semibold" className={styles.rowLabel}>Type</Text> | ||
| <Text size={200}>{score.score_type}</Text> | ||
| </div> | ||
| <div className={styles.row}> | ||
| <Text size={200} weight="semibold" className={styles.rowLabel}>Scorer</Text> | ||
| <Text size={200}>{score.scorer_type}</Text> | ||
| </div> | ||
| {categories.length > 0 && ( | ||
| <div className={styles.row}> | ||
| <Text size={200} weight="semibold" className={styles.rowLabel}>Category</Text> | ||
| <Text size={200}>{categories.join(', ')}</Text> | ||
| </div> | ||
| )} | ||
| <div className={styles.row}> | ||
| <Text size={200} weight="semibold" className={styles.rowLabel}>Outcome</Text> | ||
| <Text size={200} className={styles.chipLabel}>{resolvedOutcome}</Text> | ||
| </div> | ||
| {score.score_rationale && ( | ||
| <div className={styles.rationaleBlock}> | ||
| <Text size={200} weight="semibold">Rationale</Text> | ||
| <Text size={200} className={styles.rationaleText}>{score.score_rationale}</Text> | ||
| </div> | ||
| )} | ||
| </div> | ||
| </PopoverSurface> | ||
| </Popover> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { makeStyles, tokens } from '@fluentui/react-components' | ||
|
|
||
| export const useObjectiveHeaderStyles = makeStyles({ | ||
| root: { | ||
| flexShrink: 0, | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'baseline', | ||
| columnGap: tokens.spacingHorizontalS, | ||
| padding: `${tokens.spacingVerticalS} ${tokens.spacingHorizontalL}`, | ||
| backgroundColor: tokens.colorNeutralBackground2, | ||
| borderBottom: `1px solid ${tokens.colorNeutralStroke1}`, | ||
| borderLeft: `3px solid ${tokens.colorBrandStroke1}`, | ||
| }, | ||
| label: { | ||
| flexShrink: 0, | ||
| }, | ||
| content: { | ||
| flexGrow: 1, | ||
| minWidth: 0, | ||
| color: tokens.colorNeutralForeground1, | ||
| fontSize: tokens.fontSizeBase300, | ||
| }, | ||
| contentCollapsed: { | ||
| whiteSpace: 'nowrap', | ||
| overflow: 'hidden', | ||
| textOverflow: 'ellipsis', | ||
| }, | ||
| contentExpanded: { | ||
| whiteSpace: 'pre-wrap', | ||
| wordBreak: 'break-word', | ||
| maxHeight: '30vh', | ||
| overflowY: 'auto', | ||
| }, | ||
| toggle: { | ||
| flexShrink: 0, | ||
| minWidth: 'auto', | ||
| whiteSpace: 'nowrap', | ||
| color: tokens.colorBrandForeground1, | ||
| }, | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.