Skip to content

Add multimedia example datasets (se_relative, tse_relative) - #233

Merged
TuomasBorman merged 6 commits into
microbiome:develfrom
YihanLiu4023:add-data
Oct 1, 2026
Merged

TuomasBorman merged 6 commits into
microbiome:develfrom
YihanLiu4023:add-data

Conversation

@YihanLiu4023

Copy link
Copy Markdown
Contributor

Summary

Adds two example data objects for demonstrations and examples across miaViz:

  • se_relative — SummarizedExperiment with relative abundance data
  • tse_relative — TreeSummarizedExperiment with the same data plus a phylogenetic tree

Bundle three example objects (se_relative, tse_relative, tse_pathway)
under data/multimedia_data_demo.rda with roxygen documentation in
R/multimedia_data_demo.R, and note the addition in NEWS.

@antagomir antagomir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions.

Comment thread R/miaViz.R Outdated
Comment thread R/miaViz.R Outdated
Comment thread R/miaViz.R Outdated
Comment thread inst/scripts/multimedia_relative_data_prep.R Outdated
# samples (excluding sample i itself).
sample_ids <- tse$SampleID

tse$dysbiosis <- sapply(seq_along(tse$disease_binary), function(i) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "dysbiosis score" common thing? If it is, it could be added to e.g., mia::addAlpha

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in a way it is. But this should be a separate issue and not postpone merging this one imo (this has taken really long time already). We could make a note there to switch to that when ready,.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microsud has R package dysbiosisR but only in Github I think. Maybe it could be integrated with his permission.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in a way it is. But this should be a separate issue and not postpone merging this one imo (this has taken really long time already). We could make a note there to switch to that when ready,.

I agree that this should not be postponed because of that, but as the chapter is using "dysbiosis score", reader probably wonders how to calculate them so this could be good addition

@TuomasBorman
TuomasBorman merged commit adeebeb into microbiome:devel Oct 1, 2026
2 of 3 checks passed
TuomasBorman added a commit that referenced this pull request Oct 2, 2026
@YihanLiu4023

Copy link
Copy Markdown
Contributor Author

Hi @TuomasBorman, I noticed this PR was reverted in #234 shortly after being merged. Could you let me know the reason? Do you want to complete the "dysbiosis score" part before merging? Or is there something I should fix so it can be re-submitted to miaViz? I just noticed that the data has not been included in miaViz yet.

Happy to open a new PR with whatever changes are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants