Repository navigation
Remove the unused netlify-cli and its Netlify export steps - #284
Merged
Merged
Conversation
The manual testnet deploy job ended with two steps from the project template. They read deployments/<env>/TBTC.json and Dummy.json, which no deploy script produces any more, and passed $PORTAL_CONTRACT_ADDRESS to netlify env:set, which nothing defines. None of the Netlify secrets they need are set in the repo, and the job has never run. Those steps were the only user of netlify-cli. It's a root devDependency that pulls in about 540 packages, and it breaks the install on Node 26: its jwa 1.4.1 reads SlowBuffer.prototype at import, and Node 26 no longer has SlowBuffer. The lockfile drops those packages. No remaining package changes version.
lukasz-zimnoch
approved these changes
Oct 22, 2026
lukasz-zimnoch
added a commit
that referenced
this pull request
Oct 22, 2026
Depends on: #284 Node 22 reaches end of life on 2027-04-30. Node 26 becomes LTS on 2026-10-28 and is supported until 2029-04-30. This moves `.nvmrc` from `22` to `26`, and every `setup-node` step already reads it with `check-latest: true`. On Node 26, `pnpm install` failed inside `netlify-cli`. #284 removes `netlify-cli`, so this PR needs no dependency changes. The `jwa` override from the first version of this PR is reverted. `solidity.yml` and `dapp.yml` now also run when `.nvmrc`, the root `package.json` or `pnpm-lock.yaml` changes. Before, a change to any of those alone ran no checks. All solidity and dapp jobs pass locally on Node 26.12.1 (822 Hardhat tests). Resolves: https://linear.app/thesis-co/issue/MEZO-5237
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual
solidity-deploy-testnetjob ends with two steps from the project template. They're the only use ofnetlify-cli, and they can't work:deployments/<env>/TBTC.jsonandDummy.json, which none of the 35 deploy scripts produce.$PORTAL_CONTRACT_ADDRESStonetlify env:set, and nothing defines it.NETLIFY_SITE_IDandNETLIFY_AUTH_TOKENaren't set in the repo, andsolidity.ymlhas noworkflow_dispatchruns.netlify-clialso breaks the install on Node 26. Itsjwa1.4.1 readsSlowBuffer.prototypeat import, and Node 26 no longer hasSlowBuffer. Removing it drops about 540 packages from the lockfile, and no remaining package changes version.All solidity and dapp CI jobs pass locally on Node 22.23.4 and 26.12.1 without it (822 Hardhat tests).
Open question: the rest of
solidity-deploy-testnetdeploys to Sepolia with secrets that aren't set either. Do we still need that job?Refs: https://linear.app/thesis-co/issue/MEZO-5237