Repository navigation
fix(core): a press's release fades on the theme's exit motion tokens #9890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] A press's release now fades on the theme's exit motion tokens, `--duration-exit` and `--ease-exit`, instead of 200 ms, scaled by the theme's `tempo`, on a curve of its own. This covers every release that fades: a finger, mouse, pen or key press on a phone or tablet, and a pen press on a desktop, on buttons, cards, switches, checkboxes, list and tree rows, tabs, menu items and action groups. With the default tokens the release is 175 ms and holds its colour a little longer before it goes. A theme that changes `--duration-exit` or `--ease-exit` now changes the release too; a theme's `tempo` still does, through `--duration-exit`. Under Reduce Motion a finger's release still fades for no more than 200 ms. A mouse press on a desktop is unchanged. | ||
|
|
||
| @cixzhang |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -229,6 +229,10 @@ a measured, sourced difference exists. | |
| and MUST keep advancing at display rate through a main-thread block. It MUST | ||
| NOT animate layout properties, and MUST NOT step a frame from script when the | ||
| compositor can run the curve. | ||
| A press shows at once. Every press release that fades does so on the | ||
| theme's exit motion tokens (`--duration-exit`, `--ease-exit`), on every | ||
| device and pointer, by the owner's decision (2026-11-03); under Reduce | ||
| Motion, `design:reduced-motion` DR2 applies. | ||
|
Comment on lines
+232
to
+235
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking: a desktop mouse release on ClickableCard, SelectableCard and Thumbnail still transitions on |
||
| - **FR6 — Motion is interruptible.** A finger MUST be able to catch any | ||
| animation mid-flight at the value on screen. That value and its velocity | ||
| MUST come from the curve, not from a layout read. A new target MUST keep the | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: this says every press release fades on the exit tokens on every device and pointer, but a mouse release on ClickableCard, SelectableCard and Thumbnail still transitions on
--duration-fastand--ease-standard(for exampleClickableCard.tsxlines 124-130). Until those follow, anImplementation gap:line here would keep the record accurate.