[cixzhang]

Exact decision needed

Record component:Indicator and promote component:CheckIndicator and component:CheckboxIndicator from draft to current, recording their shipped behavior. No behavior, API, default, or DOM change.

Existing authority searched

• pnpm specs:for packages/core/src/Indicator/indicatorRegistry.ts and the three built-ins → current records that govern them: architecture:component-theming-surface, architecture:public-component-api, architecture:theme-authoring-contract, and component:Icon for the check glyph. CheckIndicator.spec.md and CheckboxIndicator.spec.md existed as draft; no component:Indicator record existed.
• Open PRs: none edits a packages/core/src/Indicator/*.spec.md record except the repository-wide schema migration.
• Open issues read: the checked-path ref (evidence for a Current-state impact line).

Decision

Three current records (approved_by: cixzhang, approved_at: 2026-10-31), one per root .doc.mjs plus the two existing sub-component records:

• Indicator.spec.md (new): the indicator names and default registry, theme replacement by name, the shared decorative prop contract, and RadioIndicator with its targets.
• CheckIndicator.spec.md and CheckboxIndicator.spec.md (promoted, existing content kept): each built-in's state marks, replacement content, decorative ownership, pass-through, and targets. Verification maps now name only real tests and list evidence gaps.

Rejected alternatives

None.

Claim scope and non-goals

Shipped behavior only, traced from indicatorRegistry.ts, useIndicator.ts, the three built-ins, Indicator.doc.mjs, Indicator.test.tsx, indicatorRegistry.test.tsx, and the CheckboxInput forced-colors cases. No requirement is added; no code is fixed. useIndicator and getIndicator stay uncontracted as API beyond the resolution the record states.

Evidence and implementation relationship

• Registry and resolution: indicatorRegistry.test.tsx and the useIndicator cases.
• Decorative contract, replacement content, radio dot, disabled state, and canonical targets: Indicator.test.tsx.
• Checkbox forced colors: CheckboxInput.test.tsx forced-colors cases.
• Evidence gaps are listed per row (for example radio sizes and hover tint, the radio forced-colors dot, refs, the check and dash targets, and reduced motion).

Current-state impact:
2. Indicator: the Tokenizer bottom sheet and the Lab MobileTokenizer and MobilePowerSearch value editor render CheckboxIndicator and RadioIndicator directly, so a theme override by name does not reach them.

1. CheckIndicator: the declared ref is null on the checked-glyph path, against architecture:public-component-api INV8 (OQ1).

Writing rubric results

• R1 narration: none; present tense; gap notes say what happens now.
• R2 research in the record: none.
• R3 evidence naming a change: none.
• R4 rejected alternatives over one line or outside a decision: none.
• R5 pull request or issue references remaining: none.
• R6 ruled open questions still listing options: none; the open questions are unruled.

Scope

• This PR contains specification records only.
• It records observable behavior and preserves equivalent internal implementations.
• Any named internal mechanism is intentionally public, names its dependent caller/system, and explains why an equivalent implementation would not satisfy the contract: none named.
• Verification states the evidence layer and failure signal without prescribing CI job/workflow topology.
• It records one intentional durable decision, not a rescue for a separable tagalong.
• The canonical knowledge owner, affected current claims, and overlapping open work are named; no ownership collision.
• Adjacent API, visual, accessibility, composition, and implementation facts remain outside scope unless this exact decision depends on them.
• Public text and artifacts contain no internal Meta context.

Validation

• pnpm check:knowledge: aligned
• Prettier: clean
• git diff --check: clean

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
astryx	Ready	Preview	Oct 31, 2026 2:22am UTC

[astracat-bot]

AI review status for this pull request.

Review status	Updated
❓ Needs maintainer input (for maintainers only)	Oct 31, 2026, 2:31 AM UTC

[github-actions]

PR Analysis Report

View Storybook for this PR · View Sandbox for this PR

Current run: The current change has no visual or preview-producing scope. Visual checks are not applicable; preview links are not shown.

---

_{Generated by PR Enrichment workflow | View current CI run}

[astracat-bot]

These three Indicator records need a few corrections before they can become current. After the fixes, an engineering owner records approval by commenting /approve-spec <full head SHA> on this pull request; the author may do this as an engineering owner.

• Indicator.spec.md says a theme's indicators entry "replaces it everywhere" (line 39, FR2), but TokenizerBottomSheet.tsx and Lab's MobileTokenizer and MobilePowerSearchValueEditor render the built-ins directly. Scope the claim and list those hosts under Current-state impact.
• Three verification rows (CheckIndicator.spec.md:143, CheckboxIndicator.spec.md:149, Indicator.spec.md:167) credit tests that never exercise glyph-path className/style/xstyle, checkbox data-disabled, or radio data-size and ref. List these as evidence gaps.
• CheckIndicator.spec.md:71 hands radio chrome to component:RadioIndicator, which does not exist. Name component:Indicator instead.

[Automated review]

[astracat-bot]

"Replaces it everywhere" doesn't hold for every shipped host. TokenizerBottomSheet.tsx (Core, not yet exposed) and Lab's MobileTokenizer and MobilePowerSearchValueEditor import CheckboxIndicator/RadioIndicator directly, so a theme's checkbox or radio entry never reaches them. Please scope this row and FR2 to hosts that resolve by name, and list these under Current-state impact.

[astracat-bot]

This test never passes style or xstyle, and it passes className only on the children path. Removing those props from CheckIndicator.tsx:166-170 (and xstyle/style at :127-130) leaves every test passing. Please list them as evidence gaps, as CheckboxIndicator's FR4 row does.

[astracat-bot]

The only disabled-state case (Indicator.test.tsx:66-73) renders RadioIndicator, and themingTargets.test.ts only checks that documented targets are a superset of rendered ones. Removing disabled: from CheckboxIndicator.tsx:205 still passes. Please add the checkbox data-disabled gap here.

[astracat-bot]

FR6 cites tests for radio data-size (root and dot) and ref, but no test asserts any of them. Please add both to this gap list.

[astracat-bot]

Thanks for scoping FR2 to by-name hosts and tightening the verification rows; the earlier findings are fixed. These records still add requirements that are not yet current, including FR2's new rule that every host MUST resolve indicators by name, so approval waits on an engineering owner commenting /approve-spec <full head SHA> on this pull request (the author may do this as an engineering owner) or saying which requirement should change. Two record fixes are needed either way:

• CheckboxIndicator.spec.md:150: the cited forced-colors tests still pass with both CanvasText rules removed from CheckboxIndicator.tsx, so list that as an evidence gap, as Indicator.spec.md does for the radio dot.
• Indicator.spec.md:102: architecture:theme-authoring-contract does not say hosts must resolve indicators by name; record the rule as a component-local decision, cite a claim that states it, or keep FR2 descriptive.

[Automated review]

[astracat-bot]

Both cited forced-colors cases still pass with the two '@media (forced-colors: active)': 'CanvasText' rules removed from CheckboxIndicator.tsx (checkmark and dash): getForcedColorsRules() matches any injected rule, and other loaded components emit the same declarations. Please add this to the row's evidence gap, as Indicator.spec.md does for the radio dot ("passes on any matching rule").

[astracat-bot]

architecture:theme-authoring-contract covers theme input and normalization ("An explicit icon, indicator, or componentIcons entry replaces the inherited entry for the same key whole") and says nothing about hosts resolving by name, and the Decision log says "No component-local decision". Please record "Hosts MUST resolve indicators by name" as a component-local decision, cite a claim that states it, or keep FR2 descriptive.

[astracat-bot]

Thanks for keeping FR2 descriptive and listing the forced-colors gap; both earlier findings are fixed. These records still add requirements that are not yet current, so approval waits on an engineering owner commenting /approve-spec <full head SHA> on the commit that carries the final text (the author may do this as an engineering owner) or saying which requirement should change. Two record fixes are needed first:

• Indicator.spec.md:120 still requires every host to draw a theme override, and :43 rejects an override that some hosts ignore, while FR2 now records three hosts it does not reach; scope both to hosts that resolve by name, or restore the rule in FR2.
• Indicator.spec.md:167 does not list FR5's radio state colours or reduced motion as evidence gaps, though the cited tests still pass with both broken in RadioIndicator.tsx.

[Automated review]

[astracat-bot]

This row requires every host to draw the override, but FR2 (line 102) now records that the Tokenizer bottom sheet and the Lab MobileTokenizer and MobilePowerSearch value editor do not. Please scope it to hosts that resolve the name (and the Review checks line 43 to match), or restore the stricter rule in FR2 with a decider.

[astracat-bot]

FR5's state colours (emphasized border, accent fill, on-accent dot) and "Transitions are instant under reduced motion" are untested too: with the reduced-motion rule removed and the checked border, fill and dot recoloured in RadioIndicator.tsx, every cited test still passes. Please add both to this row's evidence gap, as CheckboxIndicator's FR7 row does for reduced motion.

[astracat-bot]

Thanks for scoping the override statements to hosts that resolve by name and listing the radio paint gaps; both earlier findings are fixed. These records still add requirements that are not yet current, so approval waits on an engineering owner commenting /approve-spec <full SHA> on the commit that carries the final text (the author may do this as an engineering owner) or saying which requirement should change. One record fix is needed first:

• CheckboxIndicator.spec.md:147 says a missing state mark fails the cited tests, but they still pass with the checkmark and dash swapped in CheckboxIndicator.tsx; narrow the failure signal and list which mark shows in each state as an evidence gap.

[Automated review]

[astracat-bot]

This row says "A missing state mark … fails", but CheckboxIndicator renders both marks in every state and only toggles their display (CheckboxIndicator.tsx:222-250); the cited tests check that an svg exists and read data-checked. With the checkmark and dash swapped (:229, :247), every cited test still passes. Please narrow the failure signal to a removed mark element or the wrong children branch, and add the gap: no test asserts which mark is visible in each state.

[astracat-bot]

Thanks for dropping the claim that the visible mark in each state is tested; that finding is fixed. These records still add requirements that are not yet current, so approval waits on an engineering owner commenting /approve-spec <full SHA> on the commit that carries the final text (the author may do this as an engineering owner) or saying which requirement should change. Three verification rows also need narrowing so their failure signals match what the tests catch:

• CheckboxIndicator.spec.md:147: deleting the dash <span> leaves every cited test passing, so say "a removed checkmark element" and list the dash as a gap.
• CheckboxIndicator.spec.md:149: only data-checked="indeterminate" is tested, so a checked box that loses data-checked still passes; list checked-state reflection as a gap.
• Indicator.spec.md:166: the 0 case runs on CheckIndicator only, so RadioIndicator treating 0 as empty still passes; scope the signal and list RadioIndicator's case as a gap.

[Automated review]

[astracat-bot]

"A removed mark element … fails" holds for the checkmark (the falsy-children cases select svg), but no cited test looks for the dash: with the dash <span> deleted from CheckboxIndicator.tsx:241-250, every test in the cited files still passes. Please say "A removed checkmark element" and add the dash element to this row's evidence gap.

[astracat-bot]

The only reflection case renders state="indeterminate" (Indicator.test.tsx:23-32). With CheckboxIndicator.tsx:200-201 changed so a checked box carries no data-checked, every test still passes. Please name the indeterminate value as what is tested and add checked-state data-checked to the gap list.

[astracat-bot]

The 0 case renders only CheckIndicator (Indicator.test.tsx:203-211). With RadioIndicator's guard at RadioIndicator.tsx:183 changed to plain truthiness, so 0 keeps the dot, every test still passes. Please scope "0 treated as empty, fails" to CheckIndicator and list RadioIndicator's 0 case as a gap.

[astracat-bot]

The three Indicator records now hold up: the earlier verification-row fixes are in, and every failure signal and evidence gap they list matches what the cited tests catch. Approval waits only on an engineering owner approving the spec content (the new component:Indicator record and the promotion of component:CheckIndicator and component:CheckboxIndicator to current) by commenting /approve-spec <full SHA> on the commit that carries the final text; the author may do this as an engineering owner, or an owner can say which requirement should change.

[Automated review]

[cixzhang]

/approve-spec 833099c