Repository navigation
feat(ContextMenu): open from a held finger on iOS 26's timeline #8125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vjeux
wants to merge
37
commits into
meta:main
Choose a base branch
from
vjeux:uikit/c20-contextmenu-press
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,203
−283
Draft
Changes from 24 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
2bcc49a
feat(ContextMenu): open from a held finger on iOS 26's timeline
vjeux 812d3a4
test(ContextMenu): the hold's menu commits in its deciding task (red)
vjeux 0776b40
fix(ContextMenu): the hold commits its menu in the task that decides it
vjeux e8f5ca1
test(ContextMenu): the menu mounts, closed, at the hold's commit (red)
vjeux 0fbd309
fix(ContextMenu): the hold mounts the menu at its commit, closed
vjeux 32e75c7
test(ContextMenu): a mouse press closes the menu in its own document
vjeux ba77ca8
Merge commit 'c8b4cba38181263ffa8fcc897975b61154cb91b0' into HEAD
vjeux df6fd04
docs(ContextMenu): PR1 names the outside-press watch and the touch query
vjeux abb70e1
test(ContextMenu): a starved page fails the 735 ms proof by name
vjeux b8a9055
Merge commit '62c7802e873ed3d020192e8218e5e1bcd4f8fad2' into HEAD
vjeux e66ff1d
Merge commit '92784f658939912fae623dd497cd35e499e13878' into HEAD
vjeux 24c03c1
test(ContextMenu): a starved page's late timer fails by name in WebKit
vjeux 339bf7e
docs(ContextMenu): PR1 names each presentation's query subscriptions
vjeux 3d78dae
docs(ContextMenu): the record names the touch open's focus gap
vjeux 20dc83f
Merge branch 'main' into uikit/c20-contextmenu-press
cixzhang a9188e6
Merge main
vjeux a5a0e12
test(ContextMenu): a finger that lifts before 400 ms is a plain tap
vjeux a6253f3
test(ContextMenu): a late drift past 11.5 px, a known Chromium gap
vjeux 3c39a05
test(ContextMenu): a late drift past 11.5 px cancels in every engine
vjeux a4e0404
fix(ContextMenu): the menu waits for the finger's late moves
vjeux 3b76a8c
test(ContextMenu): a finger inside the tolerance at the menu's moment
vjeux 88cc0d8
fix(ContextMenu): the press reads each move's own time from the arena
vjeux 46bc0da
test(ContextMenu): coalesced late samples and an on-time move
vjeux cad79ec
fix(ContextMenu): judge each sample at its time, wait only when late
vjeux 889aded
test(ContextMenu): moves held behind a block decide before the menu
vjeux 45bfb44
fix(ContextMenu): a late menu timer waits for moves behind the block
vjeux d743922
test(ContextMenu): the press's page time comes from the arena's clock
vjeux cae3644
fix(ContextMenu): the press reads the page's time from the arena
vjeux 03eb7d7
refactor(ContextMenu): the touch layer imports its recognizer directly
vjeux f37d633
test(ContextMenu): a drift queued behind a block still ends the hold
vjeux 8575ec7
docs(records): why the press keeps its own wait, and outsidePress types
vjeux 22ae97e
docs(ContextMenu): name the measured table and the moved default
vjeux 7c8cb86
Merge main
vjeux 56b2f62
test(ContextMenu): a finger in a second document on its own clock
vjeux 650a125
Merge main
vjeux fac565a
docs(ContextMenu): the record owns the touch hold's two modules
vjeux 69e6dd8
docs(ContextMenu): the hold's comments match what this code does
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] ContextMenu closes on an outside press through the layer's outside-press watch. A mouse or pen press closes it at its `mousedown`, in the menu's own document, so a menu in an iframe or a Picture-in-Picture window no longer closes on a press in the page. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] ContextMenu opens from a held finger on iOS 26's measured timeline where the primary pointer is coarse. The hold keeps UIKit's measured moments. At 400 ms the press takes the finger: its lift no longer sends a click, and the page cannot scroll under it. The menu opens at 735 ms if the finger is still down, or as soon as it lifts after 400 ms. A finger that lifts before 400 ms, or drifts more than 11.5 px on either axis before the menu opens, gets no menu. The page stays free to scroll while the menu is up: a touch outside the menu closes it as it begins to pan, or at its lift. A touch open lights no row: the menu takes the focus, and a row lights only under the finger, as in UIKit (keyboard and pointer opens still focus the first item). A second finger cancels the press before 400 ms; after it, the menu still opens. A fine pointer (a mouse) keeps the right-click menu, and a finger there keeps today's 500 ms long press. Pass `presentation="popover"` to keep today's menu: the menu at the pointer, opened by a finger held for 500 ms. | ||
|
|
||
| @vjeux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking (a miss in earlier rounds): in UIKit the opening finger slides onto a row. Here it cannot until #8133, which is
component:ContextMenuFR5's recorded gap, so only a new finger lights a row. Suggest: "a row lights only under a finger pressed on it".