Skip to content

docs(InternationalizationProvider): order the examples locale, RTL, overrides, calendar - #11094

Merged
nynexman4464 merged 1 commit into
mainfrom
nynexman4464/docs/i18n-calendar-example-last
Nov 10, 2026
Merged

nynexman4464 merged 1 commit into
mainfrom
nynexman4464/docs/i18n-calendar-example-last

Conversation

@nynexman4464

@nynexman4464 nynexman4464 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reader impact

The InternationalizationProvider page now shows its examples in reading order: load a shipped locale, mirror the layout for right-to-left text, override one string, then show another calendar. The live calendar example used to come first.

Problem and solution fit

  • Why it was first: a component page orders its live example blocks by its doc's examples labels when a block's name matches one, and otherwise by block name. No InternationalizationProvider block name matched a label, so the blocks sorted alphabetically and "Calendar" came first.
  • Live examples: each block is now named after the code example it matches, so the page orders the live blocks by the doc's examples and the two lists read as one set. A pinned registry.slug keeps each block's registry path (examples/internationalization-provider/shipped-locale, rtl-direction, overrides, calendar), so the route lock and Sandbox export routes don't change.
  • Code examples: the order is now shipped locale, right-to-left text, override one string, local fallback catalog, Persian calendar, another calendar.
    • New code example "Mirror the layout for right-to-left text": the provider and the content element get the same dir, from getLocaleDirection. It matches the existing RTL live example.
    • "Show Calendar and DateInput in the Japanese calendar" is now "… in another calendar", since its live example switches among Gregorian, Japanese, and Buddhist. Its comment names the Minguo calendar by its standard name.

Evidence

  • The generated example registry on this branch lists the InternationalizationProvider live examples as "Load a shipped Astryx locale catalog", "Mirror the layout for right-to-left text", "Override one Astryx string", "Show Calendar and DateInput in another calendar", with registry paths unchanged.

Scope

  • One documentation change.
  • Public text and artifacts contain no internal Meta context.

Testing

  • pnpm -F docsite generate, then vitest run over apps/docsite/src/__tests__, internal/shadcn-registry, the Sandbox route manifest, CLI golden-reads, experimental-isolation, api/template, template-integration, example-checks, and docPropLiterals: 64 files, 397 tests pass.
  • pnpm -F @astryxdesign/cli typecheck:template-docs: passes.
  • Changeset coverage against the latest release tag: passes ([docs] changeset for core and cli).
  • node scripts/pre-review.mjs --base origin/main: 84 authored lines, no findings.

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 10, 2026 9:12pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 10, 2026
@astracat-bot

astracat-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 10, 2026, 9:26 PM UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · de837ed

Storybook · Sandbox · built from this PR's head

Current run: The current CI run concluded cancelled. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet.

The calendar examples now come last on the InternationalizationProvider page. Pinning registry: {slug: 'calendar'} keeps the published shadcn item at examples/internationalization-provider/calendar, which matches the route lock. The new title and the moved code example change docs only, with no public API change.

[Automated review]

@nynexman4464 nynexman4464 changed the title docs(InternationalizationProvider): list the calendar examples last docs(InternationalizationProvider): order the examples locale, RTL, overrides, calendar Nov 10, 2026
@nynexman4464
nynexman4464 force-pushed the nynexman4464/docs/i18n-calendar-example-last branch from de837ed to 0c3e288 Compare November 10, 2026 21:05

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet.

The InternationalizationProvider page now lists its live examples in the same order as its code examples, and each card carries its code example's title. The registry.slug pins keep every shadcn item at its published path, the new right-to-left example follows the provider's documented dir contract, and no public API changes.

[Automated review]

@nynexman4464
nynexman4464 merged commit 7882c60 into main Nov 10, 2026
72 checks passed
@github-actions
github-actions Bot deleted the nynexman4464/docs/i18n-calendar-example-last branch November 11, 2026 06:05

This branch was successfully deployed

1 active deployment
Preview — 0c3e288d Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant