Repository navigation
docs(InternationalizationProvider): order the examples locale, RTL, overrides, calendar - #11094
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Approved pending CI: CI has not finished on this head yet.
The calendar examples now come last on the InternationalizationProvider page. Pinning registry: {slug: 'calendar'} keeps the published shadcn item at examples/internationalization-provider/calendar, which matches the route lock. The new title and the moved code example change docs only, with no public API change.
[Automated review]
…verrides, calendar
de837ed to
0c3e288
Compare
There was a problem hiding this comment.
Approved pending CI: CI has not finished on this head yet.
The InternationalizationProvider page now lists its live examples in the same order as its code examples, and each card carries its code example's title. The registry.slug pins keep every shadcn item at its published path, the new right-to-left example follows the provider's documented dir contract, and no public API changes.
[Automated review]
Reader impact
The
InternationalizationProviderpage now shows its examples in reading order: load a shipped locale, mirror the layout for right-to-left text, override one string, then show another calendar. The live calendar example used to come first.Problem and solution fit
exampleslabels when a block's name matches one, and otherwise by block name. NoInternationalizationProviderblock name matched a label, so the blocks sorted alphabetically and "Calendar" came first.examplesand the two lists read as one set. A pinnedregistry.slugkeeps each block's registry path (examples/internationalization-provider/shipped-locale,rtl-direction,overrides,calendar), so the route lock and Sandbox export routes don't change.dir, fromgetLocaleDirection. It matches the existing RTL live example.Evidence
InternationalizationProviderlive examples as "Load a shipped Astryx locale catalog", "Mirror the layout for right-to-left text", "Override one Astryx string", "Show Calendar and DateInput in another calendar", with registry paths unchanged.Scope
Testing
pnpm -F docsite generate, thenvitest runoverapps/docsite/src/__tests__,internal/shadcn-registry, the Sandbox route manifest, CLIgolden-reads,experimental-isolation,api/template,template-integration,example-checks, anddocPropLiterals: 64 files, 397 tests pass.pnpm -F @astryxdesign/cli typecheck:template-docs: passes.[docs]changeset for core and cli).node scripts/pre-review.mjs --base origin/main: 84 authored lines, no findings.