Skip to content

test: three Switch and Tooltip marker reads decode their frames once #11074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cixzhang merged 1 commit into from
Nov 10, 2026
+17 −9
Merged

test: three Switch and Tooltip marker reads decode their frames once #11074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/core/src/Switch/__tests__/Switch.interaction.browser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
armHold,
blockMainThread,
compareCurve,
controlColor,
cubicBezier,
countBetween,
advanceFrozenPage,
Expand All @@ -38,6 +39,7 @@ import {
installPageFreeze,
installTimerGate,
markElement,
MARKER_RGB,
openStory,
releaseAnimations,
seekAnimations,
Expand All @@ -53,6 +55,7 @@ import {
traceRendering,
trackControl,
trackMarker,
trackMarkers,
waitForRest,
withStorybook,
writeEvidence,
Expand Down Expand Up @@ -2359,11 +2362,13 @@ test.describe('Switch touch presentation (UISwitch, iOS 26.2), under a finger',
castFrames: Parameters<typeof trackMarker>[1],
starts: [number, number],
): Promise<ClockedFrame[]> {
const pageTime = pageTimesOnControls(await trackControl(page, castFrames), {
ahead: await trackControl(page, castFrames, {ahead: true}),
const [control, ahead, tracked] = await trackMarkers(page, castFrames, {
colors: [controlColor(), controlColor({ahead: true}), MARKER_RGB],
});
const pageTime = pageTimesOnControls(control, {
ahead,
controlStarts: starts,
});
const tracked = await trackMarker(page, castFrames);
const shown = tracked.filter(
(f): f is typeof f & {box: NonNullable<typeof f.box>} =>
f.box != null && f.box.width > 0 && f.box.height > 0,
Expand Down Expand Up @@ -3305,8 +3310,9 @@ test.describe('Switch touch presentation (UISwitch, iOS 26.2), under a finger',
// The red channel's mean in an 8 px square: a scalar on x. With both
// controls, a WebKit proof judges each frame at its time on the
// controls' clock, at display rate.
const control = await trackControl(page, read);
const ahead = await trackControl(page, read, {ahead: true});
const [control, ahead] = await trackMarkers(page, read, {
colors: [controlColor(), controlColor({ahead: true})],
});
const colour = await trackBrightness(page, read, {...probe, size: 8});
Comment thread
astracat-bot[bot] marked this conversation as resolved.
Resolved
runs.push({
tracked: colour,
Expand Down
10 changes: 6 additions & 4 deletions packages/core/src/Tooltip/__tests__/TooltipClosedTriggerAnchor.interaction.browser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@ import {
import {
blockMainThread,
busyWindowProof,
controlColor,
markElement,
MARKER_RGB,
openStory,
startBusyControl,
startScreencast,
trackControl,
trackMarker,
trackMarkers,
withStorybook,
} from '@astryxdesign/interaction-harness';

Expand Down Expand Up @@ -89,8 +90,9 @@ test('a surface around a closed tooltip trigger keeps moving through a 500 ms ma
});
await page.waitForTimeout(150);
const frames = await cast.stop();
const tracked = await trackMarker(page, frames);
const control = await trackControl(page, frames);
const [tracked, control] = await trackMarkers(page, frames, {
colors: [MARKER_RGB, controlColor()],
});
// Judged against the compositor control in the same frames: the surface
// moves on every frame the control does.
const proof = busyWindowProof(tracked, block, {settledWithin: 2, control});
Expand Down
Loading