Repository navigation
test(core): the FR3 baseline follows main (fixes main's source check) - #10948
Conversation
…settle #10798 moved Table's virtualization capability onto a shared key, so the baseline's capabilityBrand entry is stale on main. animatedLayout gained three module-scope stores (transitionSettles, settling, settleRetimes) that coordinate glides across components; they join the F7 motion-frame group. Main's source check fails without this.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
/approve-spec 2c464c9 |
cixzhang
added
the
ci:run
|
AI review status for this pull request.
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request is reviewed as part of its stack; see the review on #10831.
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Approved. The baseline now matches main's source, so the FR3 source check passes again.
- With the old baseline, the check reports the three
animatedLayout.tssettle stores as unlisted anduseTableRowsVirtualization.ts:capabilityBrandas stale. With this baseline it lists exactly what the source has.
There is nothing to change. CI is green on this head.
[Automated review]
User impact
None for product teams. Main's required node tests fail without this: the AST-110 FR3 source check (#10807) landed with a baseline built before #10798 and before the latest glide-settle work in
motion/animatedLayout.ts, so on main it finds one listed entry the source no longer has and three stores the baseline does not list. Every pull request rebased on main inherits that failure.Problem and solution fit
useTableRowsVirtualization.ts:capabilityBrandno longer exists; its entry is removed.animatedLayout.tsnow keepstransitionSettles,settling(per document) andsettleRetimesin module scope. They coordinate glides across components, like the module's other stores, so they join the existingF7 Motion framefix group.Baseline only; no source change.
Expected behavior and authority
spec:AST-110FR3 and FR7 (the source check fails on an unlisted hit and on a stale entry).Evidence
On main
05ff3f5bwith this baseline, the check finds exactly the 254 listed entries (0 stale, 0 new); with main's current baseline it finds 1 stale and 3 new.Scope
scripts/shared-identity.baseline.json.Testing
pnpm exec vitest run --project node scripts/shared-identity.test.mjs