Repository navigation
Conversation
… Testing Library DOM Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Requesting changes: CI's first full run on this head fails in lint, the Node suite and the docsite build, and four fixes clear it.
- Miss:
apps/docsite/scripts/generate-playground-types.mjs:243only matchesreact.ForwardRefExoticComponentdeclarations, but lucide-react 1.66.0 declares its icons asLucideIcon, so the playground types every icon asanyandplayground-scope.test.tsfailsdocsite-buildanddocsite-test: match both forms, for example/^declare const (\w+): (?:react\.ForwardRefExoticComponent|LucideIcon\b)/gm. internal/stylex-capabilities/capabilities.jsonandCAPABILITIES.mdstill record StyleX 0.19.0, sointernal/stylex-capabilities/scan.test.mjsfails against the installed 0.19.1: runnode internal/stylex-capabilities/scan.mjsand commit the result.- The changeset credits no contributor, so
pnpm check:changesetsfails lint: add@cixzhangon its own line after the body. packages/cli/package.jsonpublishespostcss: ^8.5.32, but the workspace overridepostcss: ^8.5.23keeps the repository on 8.5.25, so the floor the changeset says the CLI needs is never installed or tested: raise the override to^8.5.32and regenerate the lockfile, or keep the CLI at^8.5.23and drop postcss from the changeset.
The changeset could also name @stylexjs/babel-plugin 0.19.1, which the published CLI now requires through the catalog.
[Automated review]
…or and the changeset credit
There was a problem hiding this comment.
Approved. The dependency floors stay within the release-compatibility rules (no peer range changes, every supported combination keeps working), and this update fixes all four items from the last review: the playground's lucide icon types, the StyleX capability registry, the changeset credit and the CLI's postcss floor. CI passes; one Layer entrance proof in pr-interaction (5/5) failed on its first attempt and passed on re-run.
- Non-blocking:
internal/vibe-tests/package.jsonraises postcss to^8.5.32, but the workspace override keeps the repository on 8.5.25. That is the same reason the CLI stays on^8.5.23.
[Automated review]
| "lucide-react": "^1.18.0", | ||
| "postcss": "^8.5.18", | ||
| "lucide-react": "^1.66.0", | ||
| "postcss": "^8.5.32", |
There was a problem hiding this comment.
Non-blocking: the workspace override postcss: ^8.5.23 in pnpm-workspace.yaml replaces this range, so the lockfile keeps vibe-tests on postcss 8.5.25 and ^8.5.32 is never installed here. That is the reason the CLI stays on ^8.5.23; keep ^8.5.23 here too, or raise the override.
The lockfile is regenerated against current main (vite 8.3.5 and rolldown 1.2.16 from main) with this pull request's dependency changes. It keeps the same versions as the pull request's own lockfile, except three newer patch releases that resolve inside the same ranges: lucide-react 1.67.0, baseline-browser-mapping 2.11.35, electron-to-chromium 1.5.473.
There was a problem hiding this comment.
Requesting changes: the merge with main regenerated pnpm-lock.yaml without deduplicating it, so this head installs two StyleX and two @testing-library/dom copies again. Running pnpm dedupe --lockfile-only and committing the lockfile should clear all four items below.
pnpm-lock.yamlresolves@stylexjs/stylex0.19.0 for Core, Charts, Lab and Richtext and@stylexjs/babel-pluginand@stylexjs/unplugin0.19.0 for@astryxdesign/build, beside 0.19.1 everywhere else, so CItypecheckfails in@astryxdesign/cliandapps/storybookwith "Two different types with this name exist" forStyleXClassNameTag.- Regression:
internal/stylex-capabilities/capabilities.jsonrecords 0.19.1 while Core now installs 0.19.0, sointernal/stylex-capabilities/scan.test.mjsfails ("expected '0.19.1' to be '0.19.0'"). - Core's
@testing-library/reactnow resolves@testing-library/dom10.4.1 beside the 10.4.2 that the root's@testing-library/user-eventuses, and threeDateInputtests and threelayerClickBoundarytests fail (158 of 164 pass, against all 164 on the base). - Regression: the title, the body ("one copy each of StyleX, React and
@testing-library/dom", "164 of 164") and the merge commit message ("keeps the same versions as the pull request's own lockfile") no longer describe this head, so dedupe until they hold or reword them.
Non-blocking: internal/vibe-tests/package.json still raises postcss to ^8.5.32 under the workspace's ^8.5.23 override.
[Automated review]
| @@ -712,13 +712,13 @@ importers: | |||
| version: 0.19.0 | |||
| '@stylexjs/unplugin': | |||
| specifier: '>=0.18.0' | |||
| version: 0.19.0(unplugin@3.3.0(esbuild@0.28.1)(rolldown@1.2.16)(rollup@4.62.2)(vite@8.3.5(@types/node@25.9.4)(esbuild@0.28.1)(jiti@2.7.0)(tsx@4.23.0)(yaml@2.9.0))) | |||
| version: 0.19.0(unplugin@3.7.0(esbuild@0.28.1)(rolldown@1.2.16)(rollup@4.62.2)(vite@8.3.5(@types/node@25.9.4)(esbuild@0.28.1)(jiti@2.7.0)(tsx@4.23.0)(yaml@2.9.0))) | |||
There was a problem hiding this comment.
The regenerated lockfile resolves the build package's StyleX peers to 0.19.0 here, and Core, Charts, Lab and Richtext to @stylexjs/stylex 0.19.0 (Core's importer, line 889), beside the catalog's 0.19.1. The previous head resolved every StyleX package to 0.19.1. With two copies, CI typecheck fails in @astryxdesign/cli and apps/storybook ("Two different types with this name exist" for StyleXClassNameTag). The same regeneration also left Core on @testing-library/dom 10.4.1 (line 929), which fails six DateInput and layerClickBoundary tests. Run pnpm dedupe --lockfile-only and commit the result.
| { | ||
| "version": "0.19.0", | ||
| "generatedAt": "2026-09-28T15:06:32.081Z", | ||
| "version": "0.19.1", |
There was a problem hiding this comment.
Regression: the registry records 0.19.1, but after the merge Core resolves @stylexjs/stylex 0.19.0, so scan.test.mjs:26 fails (expected '0.19.1' to be '0.19.0'). Deduplicating the lockfile brings Core back to 0.19.1 and makes this line correct again; the file itself needs no edit.
Supersedes #10650 (co-authored by dependabot).
Maintainer impact
@testing-library/domin the lockfile.^0.19.0and Storybook's@stylexjs/unplugin. chore(deps): bump the production-dependencies group across 1 directory with 30 updates #10650 had two copies, which failed the typecheck and the docsite build. Core's peer stays^0.19.0.@testing-library/dom(10.4.2): theDateInputandlayerClickBoundaryUI tests pass (164 of 164).recaststays 0.23.21, matching the shadcn override. The CLI'ssource-variantstests pass.vite: ^8.1.3, so@astryxdesign/build's optional peer keeps its published floor. chore(deps): vite 8.1.3 → 8.3.5 in the lockfile #10707 moves the installed vite.LucideIcon, so the docsite's playground type generator now matches both declaration forms. It finds 2,016 icons where it found 1.internal/stylex-capabilities) and the AGENTS.md summary are regenerated for 0.19.1. The 88 of 92 supported features are unchanged.monaco-editor0.55. With 0.57, the playground's editor model never appears to the browser contracts:window.monacohas no models, and 8playground-preview-isolationcases time out. That bump needs its own change.postcss: ^8.5.23, because the workspace's security-floor override keeps PostCSS on 8.5.25 and a higher floor would be untested.next(chore(deps): next 16.3.6 → 16.4.5 (security releases) #9788);postcss-selector-parser(chore(deps): one postcss-selector-parser, 7.1.7 #10705);@modelcontextprotocol/sdk(chore(deps): @modelcontextprotocol/sdk 1.30.0 → 1.32.2 #10706).minimumReleaseAge(the newest, lucide-react 1.66.0, is from 2026-10-31), and the lockfile passes the supply-chain policy check.Change
package.jsonfiles: chore(deps): bump the production-dependencies group across 1 directory with 30 updates #10650's ranges, exceptnext,vite,recast,postcss-selector-parser,@modelcontextprotocol/sdk, the CLI'spostcssand the docsite'smonaco-editor, which keepmain's.apps/docsite/scripts/generate-playground-types.mjs: matchesLucideIconicon declarations.internal/stylex-capabilities/*,AGENTS.md: StyleX 0.19.1.pnpm-workspace.yamlcatalog: StyleX 0.19.1 (three packages),@testing-library/react16.3.3, prettier 3.9.10, esbuild 0.28.2. vite stays.pnpm-lock.yaml: regenerated with pnpm 11.10.0, then deduplicated (pnpm dedupe --lockfile-only)..changeset/production-dependency-floors-1108.md:[fix]patch for the build package, the CLI and the seven themes.Evidence
DateInput.test.tsxandlayerClickBoundary.test.tsx: 164 passed.source-variants.test.mjs: 6 passed.scan.test.mjspasses, andcheck:changesetspasses.