Skip to content

chore(core): split the long output sentence in the group tracking test - #10515

Merged
cixzhang merged 1 commit into
meta:mainfrom
vjeux:uikit/c15-action-group-test-comment
Nov 7, 2026
Merged

cixzhang merged 1 commit into
meta:mainfrom
vjeux:uikit/c15-action-group-test-comment

Conversation

@vjeux

@vjeux vjeux commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

The @output tag in useActionGroupTracking.test.tsx's file header was one 100-word sentence. It breaks the repository's comment rule (architecture:knowledge-contracts INV29: at most 25 words in a descriptive sentence). #9699 added its last clause.

Intended invariant

INV29's sentence limits for source comments. No behavior change: the header keeps its facts and stays where it is.

Change

Evidence

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • Product changes discovered during the work were removed or split.
  • Public text and artifacts contain no internal Meta context.

Testing

Prettier and ESLint on the file, the file's 35 tests (Vitest, node and ui projects), the sentence check and pnpm review:pre pass at this head.

The useActionGroupTracking test header's @output tag was one 100-word
sentence, over the 25-word limit for a descriptive sentence in source
comments. It now reads as short sentences with the same facts.
@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 7, 2026 2:49pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 7, 2026
@astracat-bot

astracat-bot Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 7, 2026, 2:52 PM UTC

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · aeebfca

Storybook · Sandbox · built from this PR's head

Package size: no published package changed; no new dependencies.

API changes: none in this pull request

Committed API report behind this build: cli 21 rows, core 25 rows; run pnpm api:report.

Not run on this PR: add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not run on this head yet. This is a draft from a fork: once a maintainer adds the ci:run label and the pull request is marked ready for review, CI runs.

The change splits the @output tag in the useActionGroupTracking test header into twelve sentences of at most 16 words, within the 25-word limit for a descriptive comment sentence, and keeps every fact. Only comment lines change, and test files do not ship, so no changeset is needed.

[Automated review]

@cixzhang cixzhang added the ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) label Nov 7, 2026
@vjeux
vjeux marked this pull request as ready for review November 7, 2026 15:49
@cixzhang
cixzhang merged commit 256e16e into meta:main Nov 7, 2026
121 checks passed
@vjeux
vjeux deleted the uikit/c15-action-group-test-comment branch November 7, 2026 16:29

This branch was successfully deployed

1 active deployment
Preview — aeebfca8 Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants