Repository navigation
chore(core): split the long output sentence in the group tracking test - #10515
Conversation
The useActionGroupTracking test header's @output tag was one 100-word sentence, over the 25-word limit for a descriptive sentence in source comments. It now reads as short sentences with the same facts.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet. This is a draft from a fork: once a maintainer adds the ci:run label and the pull request is marked ready for review, CI runs.
The change splits the @output tag in the useActionGroupTracking test header into twelve sentences of at most 16 words, within the 25-word limit for a descriptive comment sentence, and keeps every fact. Only comment lines change, and test files do not ship, so no changeset is needed.
[Automated review]
Maintainer impact
The
@outputtag inuseActionGroupTracking.test.tsx's file header was one 100-word sentence. It breaks the repository's comment rule (architecture:knowledge-contractsINV29: at most 25 words in a descriptive sentence). #9699 added its last clause.Intended invariant
INV29's sentence limits for source comments. No behavior change: the header keeps its facts and stays where it is.
Change
useActionGroupTracking.test.tsx@output: the one sentence becomes twelve, of 4 to 16 words.paintsHighlight: falseand press-callback cases check.packages/core/package.jsonexcludes**/*.test.*).Evidence
Scope
Testing
Prettier and ESLint on the file, the file's 35 tests (Vitest, node and ui projects), the sentence check and
pnpm review:prepass at this head.