Skip to content

fix(llm): allow registered custom providers in LlmConfig validation #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
littfed wants to merge 1 commit into from
Closed

fix(llm): allow registered custom providers in LlmConfig validation #7655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions mem0/llms/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,10 @@ class LlmConfig(BaseModel):

@field_validator("config")
def validate_config(cls, v, values):
from mem0.utils.factory import LlmFactory

provider = values.data.get("provider")
if provider in (
"openai",
"ollama",
"anthropic",
"groq",
"together",
"aws_bedrock",
"litellm",
"azure_openai",
"openai_structured",
"azure_openai_structured",
"gemini",
"deepseek",
"minimax",
"xai",
"sarvam",
"lmstudio",
"vllm",
"langchain",
):
if provider in LlmFactory.provider_to_class:
return v
else:
raise ValueError(f"Unsupported LLM provider: {provider}")
21 changes: 21 additions & 0 deletions tests/utils/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,24 @@ def test_dict_config_not_mutated_by_kwargs():
LlmFactory.create("openai", config, api_key="secret")

assert config == {"model": "gpt-4o-mini"}


def test_llm_config_accepts_registered_provider():
from mem0.llms.configs import LlmConfig

provider_name = "test_custom_provider"
try:
LlmFactory.register_provider(provider_name, "mypkg.CustomLLM")
llm_config = LlmConfig(provider=provider_name, config={})
assert llm_config.provider == provider_name
finally:
LlmFactory.provider_to_class.pop(provider_name, None)


def test_llm_config_rejects_unsupported_provider():
import pytest
from mem0.llms.configs import LlmConfig

with pytest.raises(ValueError, match="Unsupported LLM provider: unknown_provider"):
LlmConfig(provider="unknown_provider", config={})

Loading