Add link href support. - #5
Open
neojski wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for sharing the code! I agree that it would be "better" here to have Element contain Node, so this method could be implemented on Element, but this would also add some extra boilerplate elsewhere.
In Servo, I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I've implemented basic
linksupport. I'm pretty sure you don't want to merge it because you don't want this toy browser to grow uncontrollably. But I wanted to leave it here and discuss a little bit.So the tricky thing here is that I implemented
get_elements_by_tag_nameonNode. But it is not aNodemethod but ratherElementmethod. ButElementitself in our case (ElementData) does not havechildrenavailable.I'm not really sure what to think about the relationship between
ElementandNode. It's likeElementis a type ofNodebut with limited functionality. It's not inheritance either.I checked and servo's
Elementsimply hasNodeinside of it. Andis casting
ElementontoNode. Is this cast something more than justself.node?