Skip to content

docs: include Vehicle.Actuators.Common in Actuators troubleshooting logs - #14872

Merged
DonLakeFlyer merged 1 commit into
mavlink:masterfrom
DonLakeFlyer:docs/actuators-common-log-category
Aug 15, 2026
Merged

docs: include Vehicle.Actuators.Common in Actuators troubleshooting logs#14872
DonLakeFlyer merged 1 commit into
mavlink:masterfrom
DonLakeFlyer:docs/actuators-common-log-category

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Follow-up to #14862, addressing the Copilot review comments left on that PR:

  • Add Vehicle.Actuators.Common to the log capture instructions — the show-ui-if condition evaluation details are emitted under this category (src/Vehicle/Actuators/Common.cc), not the three categories previously listed.
  • Reword the Condition 'show-ui-if' evaluated to false interpretation, which was too strong: Condition::evaluate() also returns false when the referenced parameter is unavailable, so it can indicate a metadata/firmware compatibility problem rather than deliberate hiding. The table now describes the result neutrally and points to the Vehicle.Actuators.Common messages for the actual cause.

Copilot AI balanced review requested due to automatic review settings August 15, 2026 19:19
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed (likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

This comment was marked as resolved.

@DonLakeFlyer
DonLakeFlyer force-pushed the docs/actuators-common-log-category branch from 734f57c to 889a80e Compare August 15, 2026 19:36
@DonLakeFlyer
DonLakeFlyer requested a balanced review from Copilot August 15, 2026 19:37
@DonLakeFlyer DonLakeFlyer added this to the Release V5.1 milestone Aug 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

docs/en/qgc-user-guide/setup_view/px4/actuators.md:64

  • This still attributes every false result to the metadata, but Condition::evaluate() also returns false when the referenced parameter is unavailable (src/Vehicle/Actuators/Common.cc:194-199). It also does not direct users to the newly enabled category that distinguishes this case. Describe the result neutrally and name the Evaluating [show-ui-if] message so the troubleshooting guidance provides the actual cause.
| `Vehicle.Actuators.PX4AutoPilotPlugin` | `Condition 'show-ui-if' evaluated to false` | The vehicle's metadata indicated the page should not be shown. This can be intentional for your configuration, or a firmware/metadata mismatch. Attach the saved log to a support request. |

@DonLakeFlyer
DonLakeFlyer merged commit e409a94 into mavlink:master Aug 15, 2026
27 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the docs/actuators-common-log-category branch August 15, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants