Skip to content

fix(Windows): use app name as file description - #14866

Open
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:fix/windows-file-description
Open

fix(Windows): use app name as file description#14866
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:fix/windows-file-description

Conversation

@rubenp02

Copy link
Copy Markdown
Contributor

Description

Updates the Windows file description to use the application name instead of the project description, matching the fallback RC template, as well as common Windows practice.

Previously, Windows prompts such as the Firewall popup would display the generic project description instead of the application name. The application name is now shown instead, as expected.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

Updates the Windows file description to use the application name instead of the
project description, matching the fallback RC template, as well as common
Windows practice.

Previously, Windows prompts such as the Firewall popup would display the generic
project description instead of the application name. The application name is now
shown instead, as expected.
@rubenp02
rubenp02 marked this pull request as ready for review August 15, 2026 01:36
@rubenp02
rubenp02 requested a review from HTRamsey as a code owner August 15, 2026 01:36
Copilot AI balanced review requested due to automatic review settings August 15, 2026 01:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.78%. Comparing base (f29efd3) to head (1bc784b).
⚠️ Report is 284 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14866      +/-   ##
==========================================
+ Coverage   25.47%   33.78%   +8.31%     
==========================================
  Files         769      933     +164     
  Lines       65912    84615   +18703     
  Branches    30495    39120    +8625     
==========================================
+ Hits        16788    28590   +11802     
+ Misses      37285    36817     -468     
- Partials    11839    19208    +7369     
Flag Coverage Δ
unittests 33.78% <ø> (+8.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 639 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f0d6a...1bc784b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed (likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants