Skip to content

feat(QGCCorePlugin): allow hiding initial setup sections - #14864

Open
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:feature/initial-setup-section-visibility
Open

feat(QGCCorePlugin): allow hiding initial setup sections#14864
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:feature/initial-setup-section-visibility

Conversation

@rubenp02

Copy link
Copy Markdown
Contributor

Description

Makes it possible for custom builds to hide either the Vehicle Preferences or Measurement Units section from the initial setup prompt. Hiding both sections omits the prompt. This restores the control available before the two prompts were merged.

In addition to this, this commit fixes a bug where the initial setup prompt showed an empty Vehicle Preferences section when only one firmware and one vehicle type are supported. Its heading and description now hide with its controls. The visibility logic that drives this now lives in QGCCorePlugin instead of QML.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

Makes it possible for custom builds to hide either the Vehicle
Preferences or Measurement Units section from the initial setup prompt.
Hiding both sections omits the prompt. This restores the control
available before the two prompts were merged.

In addition to this, this commit fixes a bug where the initial setup
prompt showed an empty Vehicle Preferences section when only one
firmware and one vehicle type are supported. Its heading and description
now hide with its controls. The visibility logic that drives this now
lives in QGCCorePlugin instead of QML.
Copilot AI balanced review requested due to automatic review settings August 14, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.76%. Comparing base (f29efd3) to head (46bd468).
⚠️ Report is 284 commits behind head on master.

Files with missing lines Patch % Lines
src/API/QGCCorePlugin.cc 27.27% 3 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14864      +/-   ##
==========================================
+ Coverage   25.47%   33.76%   +8.29%     
==========================================
  Files         769      933     +164     
  Lines       65912    84625   +18713     
  Branches    30495    39124    +8629     
==========================================
+ Hits        16788    28576   +11788     
+ Misses      37285    36840     -445     
- Partials    11839    19209    +7370     
Flag Coverage Δ
unittests 33.76% <27.27%> (+8.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/QGCCorePlugin.h 76.19% <ø> (+21.64%) ⬆️
src/API/QGCCorePlugin.cc 43.33% <27.27%> (+34.41%) ⬆️

... and 637 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f0d6a...46bd468. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 75 failed, 7 skipped.

Test Results

linux-coverage-integration: 43 passed, 0 skipped
linux-coverage-unit: 132 passed, 0 skipped
linux-sanitizers-integration: 25 passed, 0 skipped
linux-sanitizers-unit: 132 passed, 0 skipped
Total: 332 passed, 0 skipped

Code Coverage

Coverage: 69.5%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 252.64 MB
QGroundControl-aarch64 176.49 MB
QGroundControl-installer-AMD64 137.90 MB
QGroundControl-installer-AMD64-ARM64 80.42 MB
QGroundControl-installer-ARM64 109.18 MB
QGroundControl-linux 84.51 MB
QGroundControl-mac 84.51 MB
QGroundControl-x86_64 188.74 MB
No baseline available for comparison

Updated: 2026-08-14 16:18:05 UTC • Commit: 46bd468 • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants