Skip to content

refactor(QGCPalette): rename brand color roles - #14863

Open
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:refactor/brand-palette-names
Open

refactor(QGCPalette): rename brand color roles#14863
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:refactor/brand-palette-names

Conversation

@rubenp02

Copy link
Copy Markdown
Contributor

Description

Replaces color-specific branding names with primary and accent roles. Updates custom-build example and QML consumers accordingly.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes) Note: It will create minor merge conflicts on custom builds that modify the color palette.
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

Replaces color-specific branding names with primary and accent roles.
Updates custom-build example and QML consumers accordingly.
Copilot AI balanced review requested due to automatic review settings August 14, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.74%. Comparing base (f29efd3) to head (fad8b71).
⚠️ Report is 284 commits behind head on master.

Files with missing lines Patch % Lines
src/QmlControls/QGCPalette.cc 0.00% 0 Missing and 2 partials ⚠️
src/QmlControls/QGCPalette.h 0.00% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14863      +/-   ##
==========================================
+ Coverage   25.47%   33.74%   +8.27%     
==========================================
  Files         769      933     +164     
  Lines       65912    84615   +18703     
  Branches    30495    39120    +8625     
==========================================
+ Hits        16788    28551   +11763     
+ Misses      37285    36882     -403     
- Partials    11839    19182    +7343     
Flag Coverage Δ
unittests 33.74% <0.00%> (+8.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/QmlControls/QGCPalette.cc 18.18% <0.00%> (ø)
src/QmlControls/QGCPalette.h 3.84% <0.00%> (ø)

... and 638 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f0d6a...fad8b71. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 75 failed, 7 skipped.

Test Results

linux-coverage-integration: 43 passed, 0 skipped
linux-coverage-unit: 132 passed, 0 skipped
linux-sanitizers-integration: 25 passed, 0 skipped
linux-sanitizers-unit: 132 passed, 0 skipped
Total: 332 passed, 0 skipped

Code Coverage

Coverage: 69.5%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 252.68 MB
QGroundControl-aarch64 176.49 MB
QGroundControl-installer-AMD64 137.92 MB
QGroundControl-installer-AMD64-ARM64 80.44 MB
QGroundControl-installer-ARM64 109.18 MB
QGroundControl-linux 84.51 MB
QGroundControl-mac 84.50 MB
QGroundControl-x86_64 188.74 MB
No baseline available for comparison

Updated: 2026-08-14 15:17:13 UTC • Commit: fad8b71 • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants