Scrub branch-named plans in /doc-review - #144
Merged
Merged
Conversation
Implementation plans are moving from a generic PLAN.md to <branch>-PLAN.md in the repository root, and /handoff already names them that way (PR #142). The user-scope /doc-review was missed, and it shadows a repository's own copy, so its artifact scrub looked only for a bare PLAN.md and skipped the plan /ship-it posts to the pull request. The scrub now matches *PLAN.md, which covers branch-named plans and still catches a legacy PLAN.md. The prose describing what /ship-it publishes names *-PLAN.md to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/doc-reviewnow matches*PLAN.md, so it covers branch-named<branch>-PLAN.mdplans and still catches a legacyPLAN.md/ship-itpublishes now names*-PLAN.md, matching/handoffafter Point /handoff at per-branch plan files #142findkeeps-maxdepth 1Test plan
markdownlintwith.markdown-lint.ymlpasses onhome/.claude/commands/doc-review.mdfindexpression, run against a scratch directory, matchesPLAN.mdanddoc-review-plans-PLAN.mdand skipsREADME.mdandsub/x-PLAN.mdgit grep 'PLAN\.md'on this branch finds no remaining barePLAN.mdreference outside the legacy mentions inhandoff.mdand the.markdownlintignoregloblintpasses