Skip to content

fix: ignore RUSTSEC-2026-0387 (crypto-bigint) in cargo-deny - #351

Merged
AntonD3 merged 2 commits into
mainfrom
fix/ignore-rustsec-2026-0387
Nov 4, 2026
Merged

AntonD3 merged 2 commits into
mainfrom
fix/ignore-rustsec-2026-0387

Conversation

@AntonD3

@AntonD3 AntonD3 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

crypto-bigint 0.5.5 has timing variability in operations meant to be constant-time. Patched in >=0.7.6, which this graph cannot reach: elliptic-curve 0.13.8 requires crypto-bigint ^0.5, and the stack comes in through zkevm_opcode_defs, which pins k256/p256 to 0.13.* — as does every
published version of it. cargo update resolves nothing newer; the bump has to land in zksync-protocol first.

Not reachable here: zkevm_opcode_defs only re-exports k256/p256, this repo uses it for address/enum constants and the SHA-256 bytecode hash, and no symbol from crypto-bigint, elliptic-curve, k256, p256 or ecdsa is linked into zksolc.

Unblocks cargo-deny on all open PRs. Revisit when zkevm_opcode_defs moves to k256/p256 0.14.

🤖 Generated with Claude Code

crypto-bigint 0.5.5 has timing variability in operations meant to be
constant-time. The patched versions are >=0.7.6, which this dependency
graph cannot reach: elliptic-curve 0.13.8 requires crypto-bigint ^0.5,
and the stack arrives through zkevm_opcode_defs, which pins k256 and
p256 to 0.13.*. Every published zkevm_opcode_defs does, so there is no
release to move to and `cargo update` resolves nothing newer; the bump
has to land in zksync-protocol first.

The advisory is not reachable here. zkevm_opcode_defs only re-exports
k256 and p256; this repository uses it for address and enum constants
and the SHA-256 bytecode hash. No symbol from crypto-bigint,
elliptic-curve, k256, p256 or ecdsa is linked into the zksolc binary,
and a compiler holds no secret material to leak through timing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.54%. Comparing base (bdd4826) to head (6d04ff4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files         124      124           
  Lines       11308    11308           
=======================================
  Hits         8543     8543           
  Misses       2765     2765           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vladbochok
vladbochok previously approved these changes Nov 4, 2026
Comment thread deny.toml Resolved
Per review. The full rationale stays in the commit that added the entry.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@AntonD3
AntonD3 merged commit 9f4450c into main Nov 4, 2026
15 checks passed
@AntonD3
AntonD3 deleted the fix/ignore-rustsec-2026-0387 branch November 4, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants