Repository navigation
fix: ignore RUSTSEC-2026-0387 (crypto-bigint) in cargo-deny - #351
Merged
Merged
Conversation
crypto-bigint 0.5.5 has timing variability in operations meant to be constant-time. The patched versions are >=0.7.6, which this dependency graph cannot reach: elliptic-curve 0.13.8 requires crypto-bigint ^0.5, and the stack arrives through zkevm_opcode_defs, which pins k256 and p256 to 0.13.*. Every published zkevm_opcode_defs does, so there is no release to move to and `cargo update` resolves nothing newer; the bump has to land in zksync-protocol first. The advisory is not reachable here. zkevm_opcode_defs only re-exports k256 and p256; this repository uses it for address and enum constants and the SHA-256 bytecode hash. No symbol from crypto-bigint, elliptic-curve, k256, p256 or ecdsa is linked into the zksolc binary, and a compiler holds no secret material to leak through timing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 124 124
Lines 11308 11308
=======================================
Hits 8543 8543
Misses 2765 2765 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vladbochok
previously approved these changes
Nov 4, 2026
Per review. The full rationale stays in the commit that added the entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
vladbochok
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto-bigint 0.5.5has timing variability in operations meant to be constant-time. Patched in>=0.7.6, which this graph cannot reach:elliptic-curve 0.13.8requirescrypto-bigint ^0.5, and the stack comes in throughzkevm_opcode_defs, which pinsk256/p256to0.13.*— as does everypublished version of it.
cargo updateresolves nothing newer; the bump has to land inzksync-protocolfirst.Not reachable here:
zkevm_opcode_defsonly re-exportsk256/p256, this repo uses it for address/enum constants and the SHA-256 bytecode hash, and no symbol fromcrypto-bigint,elliptic-curve,k256,p256orecdsais linked intozksolc.Unblocks cargo-deny on all open PRs. Revisit when
zkevm_opcode_defsmoves tok256/p2560.14.🤖 Generated with Claude Code