Skip to content

feat: add docusaurus icon - #3579

Open
Airkro wants to merge 1 commit into
material-extensions:mainfrom
nice-move:feat/docusaurus-icon
Open

Airkro wants to merge 1 commit into
material-extensions:mainfrom
nice-move:feat/docusaurus-icon

Conversation

@Airkro

@Airkro Airkro commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

this PR add icon for Docusaurus

Contribution Guidelines

@github-actions github-actions Bot added the icons PR with new icons label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@Airkro
Airkro force-pushed the feat/docusaurus-icon branch 5 times, most recently from f52715f to 7bd048e Compare September 5, 2026 17:39
@anandghegde anandghegde mentioned this pull request Sep 14, 2026
2 tasks done
@Airkro

Airkro commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

So what are the current obstacles?

@PKief

PKief commented Sep 15, 2026

Copy link
Copy Markdown
Member

The icon is not following our contribution guidelines, it doesn't fit into this project. Please read the Contributions.md file and align your icon with our existing folder icons so that we can proceed with this PR.

@Airkro

Airkro commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

I understand your strictness, but I am genuinely confused by the guidelines; I cannot pinpoint the exact issue—is it the color or the grid?

@lucas-labs

Copy link
Copy Markdown
Member

I understand your strictness, but I am genuinely confused by the guidelines; I cannot pinpoint the exact issue—is it the color or the grid?

Hi there, there are a few issues:

image
  • grid is one, as you noticed
  • file icons need a margin of at least 1px when rendered at 16x16px
  • IMO, the motif (docusaurus logo) in the folder icon is too large, at small sizes it's quite hard to notice there's a folder behind the logo.

Also, most of our folder icons use monochrome motives:

image

One color for the folder, a lighter shade of the same color for the motiflogo.

There are some exceptions, not many. But we think two-color folder icons fit better within the theme.

@Airkro
Airkro force-pushed the feat/docusaurus-icon branch from 7bd048e to d9cd360 Compare October 10, 2026 06:43
@Airkro
Airkro force-pushed the feat/docusaurus-icon branch from d9cd360 to 7fd88b1 Compare October 10, 2026 07:03
@Airkro

Airkro commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

@PKief, @lucas-labs

Please check again.

@zm-develops

zm-develops commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Could you use the icon from #1770?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants