Conversation
✅ Deploy Preview for masterpoint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds an explicit redirect from "/404" to "/404.html" with status 404 in netlify.toml, placed before the existing catch-all redirect "/*" to "/404.html" (status 404). No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
netlify.toml (1)
41-45: Also handle the trailing slash variant/404/(optional but recommended)If
/404/exists (common with static site generators), it’ll behave like/404and may also need to be forced to return 404.Please confirm whether
/404/resolves to a page in the deployed site. If yes, add the following block right after the/404rule:[[redirects]] from = "/404" to = "/404.html" status = 404 force = true +[[redirects]] +from = "/404/" +to = "/404.html" +status = 404 +force = true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
netlify.toml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
netlify.toml
📄 CodeRabbit Inference Engine (CLAUDE.md)
Add redirects to netlify.toml (e.g., /updates/* → /blog/*)
Files:
netlify.toml
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: masterpointio/masterpoint.io#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-31T21:30:32.227Z
Learning: Applies to netlify.toml : Add redirects to netlify.toml (e.g., /updates/* → /blog/*)
Learnt from: CR
PR: masterpointio/masterpoint.io#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-31T21:30:32.227Z
Learning: Build settings, redirects, and Hugo version are managed in netlify.toml
📚 Learning: 2025-07-31T21:30:32.227Z
Learnt from: CR
PR: masterpointio/masterpoint.io#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-31T21:30:32.227Z
Learning: Applies to netlify.toml : Add redirects to netlify.toml (e.g., /updates/* → /blog/*)
Applied to files:
netlify.toml
📚 Learning: 2025-07-31T21:30:32.227Z
Learnt from: CR
PR: masterpointio/masterpoint.io#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-31T21:30:32.227Z
Learning: Build settings, redirects, and Hugo version are managed in netlify.toml
Applied to files:
netlify.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - masterpoint
- GitHub Check: Header rules - masterpoint
- GitHub Check: Pages changed - masterpoint
| [[redirects]] | ||
| from = "/404" | ||
| to = "/404.html" | ||
| status = 404 | ||
|
|
There was a problem hiding this comment.
Add force = true to ensure this rule overrides the existing /404 file
If Hugo outputs /404/index.html, Netlify will serve that file with 200 unless the redirect is forced. Without force = true, this rule may not apply, and the status will remain 200, defeating the PR’s objective.
Apply this diff:
[[redirects]]
from = "/404"
to = "/404.html"
status = 404
+force = true🤖 Prompt for AI Agents
In netlify.toml around lines 41 to 45, the redirect from "/404" to "/404.html"
lacks force = true so it may not override an existing /404 file (e.g., Hugo's
/404/index.html) and Netlify could serve it with 200; update the redirect entry
to include force = true so Netlify will apply the 404 status unconditionally for
requests to /404.
2 participants
I saw this!
For all the pages that are actually redirected to 404.html, it does indeed already return
404.But if someone explicitly went to 404, it doesn't return
404.Add this in. Why not.
Summary by CodeRabbit